Table of Contents
🚀 Major Features and Enhancements
New official logo
Many of you probably have already seen the new logo, but now it’s time to actually ship it. The new logo was long ago decided (see #1663).
We decided it’s time to have a modernized logo and get rid of the gun. This allows to include the logo anywhere without offense.
The official logo is also without a tagline (such as “Code Quality Matters!”) as the tagline created some controversies. Without a tagline, we are not limited in the direction of future development of PMD.
The new logo is available from the Logo Project Page.
Revamped Java
The Java grammar has been refactored substantially in order to make it easier to maintain and more correct regarding the Java Language Specification. It supports now also the edge-cases where PMD 6 was failing (e.g. annotations were not supported everywhere). Changing the grammar entails a changed AST and therefore changed rules. The PMD built-in rules have all been upgraded and many bugs have been fixed on the way. Unfortunately, if you are using custom rules, you will most probably need to accommodate these changes yourself.
The type resolution framework has been rewritten from scratch and should now cover the entire Java spec correctly. The same is true for the symbol table. PMD 6 on the other hand has always had problems with advanced type inference, e.g. with lambdas and call chains. Since it was built on the core reflection API, it also was prone to linkage errors and classloader leaks for instance. PMD 7 does not need to load classes, and does not have these problems.
The AST exposes much more semantic information now. For instance, you can jump from a method call to
the declaration of the method being called, or from a field access to the field declaration. These
improvements allow interesting rules to be written that need precise knowledge of the types
in the program, for instance to detect UnnecessaryBoxing
or UseDiamondOperator
.
These are just a small preview of the new rules we will be adding in the PMD 7 release cycle.
Overall, the changes to the parser, AST, type resolution and symbol table code has made PMD for Java significantly faster. On average, we have seen ~2-3X faster analysis, but as usual, this may change depending on your workload, configuration and ruleset.
Contributors: Clément Fournier (@oowekyala), Andreas Dangel (@adangel), Juan Martín Sotuyo Dodero (@jsotuyod)
Note: The full detailed documentation of the changes to the Java AST are available in the Migration Guide for PMD 7
Revamped Command Line Interface
PMD now ships with a unified Command Line Interface for both Linux/Unix and Windows. Instead of having a collection
of scripts for the different utilities shipped with PMD, a single script pmd
(pmd.bat
for Windows) can now
launch all utilities using subcommands, e.g. pmd check
, pmd designer
. All commands and options are thoroughly
documented in the help, with full color support where available. Moreover, efforts were made to provide consistency
in the usage of all PMD utilities.
$ Usage: pmd [-hV] [COMMAND]
-h, --help Show this help message and exit.
-V, --version Print version information and exit.
Commands:
check The PMD standard source code analyzer
cpd Copy/Paste Detector - find duplicate code
designer The PMD visual rule designer
cpd-gui GUI for the Copy/Paste Detector
Warning: May not support the full CPD feature set
ast-dump Experimental: dumps the AST of parsing source code
Exit Codes:
0 Successful analysis, no violations found
1 An unexpected error occurred during execution
2 Usage error, please refer to the command help
4 Successful analysis, at least 1 violation found
For instance, where you previously would have run
run.sh pmd -d src -R ruleset.xml
you should now use
pmd check -d src -R ruleset.xml
or even better, omit using -d
/ --dir
and simply pass the sources at the end of the parameter list
pmd check -R ruleset.xml src
Multiple source directories can be passed, such as:
pmd check -R ruleset.xml src/main/java src/test/java
And the exact same applies to CPD:
pmd cpd --minimum-tokens 100 src/main/java
Additionally, the CLI for the check
command has been enhanced with a progress bar, which interactively displays the
current progress of the analysis.
This can be disabled with the --no-progress
flag.
Finally, we now provide a completion script for Bash/Zsh to further help daily usage.
To use it, edit your ~/.bashrc
/ ~/.zshrc
file and add the following line:
source <(pmd generate-completion)
Contributors: Juan Martín Sotuyo Dodero (@jsotuyod)
Full Antlr support
PMD 6 only supported JavaCC based grammars, but with Antlr parsers can be generated as well. Languages backed by an Antlr grammar are now fully supported. This means, it’s now possible not only to use Antlr grammars for CPD, but we can actually build full-fledged PMD rules for them as well. Both the traditional Java visitor rules, and the simpler XPath rules are available to users. This allows to leverage existing grammars.
We expect this to enable both our dev team and external contributors to largely extend PMD usage for more languages.
Two languages (Swift and Kotlin) already use this new possibility.
See the documentation page Adding a new language with ANTLR for instructions on how to use this new feature.
Contributors: Lucas Soncini (@lsoncini), Matías Fraga (@matifraga), Tomás De Lucca (@tomidelucca)
Updated PMD Designer
This PMD release ships a new version of the pmd-designer. The designer artifact has been renamed from “pmd-ui” to “pmd-designer”. While the designer still works with Java 8, the recommended Java Runtime is Java 11 (or later) with OpenJFX 17 (or later).
For the detailed changes, see
- PMD Designer Changelog (7.0.0).
- PMD Designer Changelog (7.0.0-rc4).
- PMD Designer Changelog (7.0.0-rc1).
New CPD report format cpdhtml-v2.xslt
Thanks to @mohan-chinnappan-n a new CPD report format has been added which features a data table. It uses an XSLT stylesheet to convert CPD’s XML format into HTML.
See the example report.
Contributors: Mohan Chinnappan (@mohan-chinnappan-n)
🎉 Language Related Changes
New: CPD support for Apache Velocity Template Language (VTL)
PMD supported Apache Velocity for a very long time, but the CPD integration never got finished.
This is now done and CPD supports Apache Velocity Template language for detecting copy and paste.
It is shipped in the module pmd-velocity
.
New: CPD support for Coco
Thanks to a contribution, CPD now supports Coco, a modern programming language
designed specifically for building event-driven software. It is shipped in the new
module pmd-coco
.
Contributors: Wener (@wener-tiobe)
New: CPD support for Julia
Thanks to a contribution, CPD now supports the Julia language. It is shipped
in the new module pmd-julia
.
Contributors: Wener (@wener-tiobe)
New: CPD support for TypeScript
Thanks to a contribution, CPD now supports the TypeScript language. It is shipped
with the rest of the JavaScript support in the module pmd-javascript
.
Contributors: Paul Guyot (@pguyot)
New: Java 21 and 22 Support
This release of PMD brings support for Java 21 and 22. There are the following new standard language features, that are supported now:
- JEP 456: Unnamed Variables & Patterns (Java 22)
- JEP 440: Record Patterns (Java 21)
- JEP 441: Pattern Matching for switch (Java 21)
PMD also supports the following preview language features:
- JEP 447: Statements before super(…) (Preview) (Java 22)
- JEP 459: String Templates (Second Preview) (Java 21 and 22)
- JEP 463: Implicitly Declared Classes and Instance Main Methods (Second Preview) (Java 21 and 22)
In order to analyze a project with PMD that uses these preview language features,
you’ll need to enable it via the environment variable PMD_JAVA_OPTS
and select the new language
version 22-preview
:
export PMD_JAVA_OPTS=--enable-preview
pmd check --use-version java-22-preview ...
Note: Support for Java 19 and Java 20 preview language features have been removed. The versions “19-preview” and “20-preview” are no longer available.
New: Kotlin support
PMD now supports Kotlin as an additional language for analyzing source code. It is based on the official kotlin Antlr grammar for Kotlin 1.8. Java-based rules and XPath-based rules are supported.
We are shipping the following rules:
FunctionNameTooShort
finds functions with a too short name.OverrideBothEqualsAndHashcode
finds classes with only eitherequals
orhashCode
overridden, but not both. This leads to unexpected behavior once instances of such classes are used in collections (Lists, HashMaps, …).
Contributors: Jeroen Borgers (@jborgers), Peter Paul Bakker (@stokpop)
New: Swift support
Given the full Antlr support, PMD now fully supports Swift for creating rules. Previously only CPD was supported.
Note: There is only limited support for newer Swift language features in the parser, e.g. Swift 5.9 (Macro Expansions) are supported, but other features are not.
We are pleased to announce we are shipping a number of rules starting with PMD 7.
ForceCast
flags all force casts, making sure you are defensively considering all types. Having the application crash shouldn’t be an option.ForceTry
flags all force tries, making sure you are defensively handling exceptions. Having the application crash shouldn’t be an option.ProhibitedInterfaceBuilder
flags any usage of interface builder. Interface builder files are prone to merge conflicts, and are impossible to code review, so larger teams usually try to avoid it or reduce its usage.UnavailableFunction
flags any function throwing afatalError
not marked as@available(*, unavailable)
to ensure no calls are actually performed in the codebase.
Contributors: Lucas Soncini (@lsoncini), Matías Fraga (@matifraga), Tomás De Lucca (@tomidelucca)
Changed: Apex Support: Replaced Jorje with fully open source front-end
When PMD added Apex support with version 5.5.0, it utilized the Apex Jorje library to parse Apex source and generate an AST. This library is however a binary-blob provided as part of the Salesforce Extensions for VS Code, and it is closed-source.
This causes problems, if binary blobs are not allowed by e.g. a company-wide policy. In that case, the Jorje library prevented that PMD Apex could be used at all.
Also having access to the source code, enhancements and modifications are easier to do.
Under the hood, we use two open source libraries instead:
- apex-parser originally by Kevin Jones (@nawforce). This project provides the grammar for a ANTLR based parser.
- Summit-AST by Google (@google) This project translates the ANTLR parse tree into an AST, that is similar to the AST Jorje provided. Note: This is not an official Google product.
Although the parsers is completely switched, there are only little known changes to the AST.
These are documented in the Migration Guide for PMD 7: Apex AST.
With the new Apex parser, the new language constructs like
User Mode Database Operations
and the new Null Coalescing Operator ??
can be parsed now. PMD should be able to parse Apex code up to version 60.0 (Spring ‘24).
See #3766 for details.
Contributors: Aaron Hurst (@aaronhurst-google), Edward Klimoshenko (@eklimo)
Changed: CPP can now ignore identifiers in sequences (CPD)
- New command line option for CPD:
--ignore-sequences
. - This option is used for CPP only: with the already existing option
--ignore-literal-sequences
, only literals were ignored. The new option additionally ignores identifiers as well in sequences. - See PR #4470 for details.
Changed: Groovy Support (CPD)
- We now support parsing all Groovy features from Groovy 3 and 4.
- We now support suppression through
CPD-ON
/CPD-OFF
comment pairs. - See PR #4726 for details.
Changed: HTML support
Support for HTML was introduced in PMD 6.55.0 as an experimental feature. With PMD 7.0.0 this is now considered stable.
Changed: JavaScript support
The JS specific parser options have been removed. The parser now always retains comments and uses version ES6. The language module registers a couple of different versions. The latest version, which supports ES6 and also some new constructs (see Rhino), is the default. This should be fine for most use cases.
Changed: Language versions
We revisited the versions that were defined by each language module. Now many more versions are defined for each language. In general, you can expect that PMD can parse all these different versions. There might be situations where this fails and this can be considered a bug. Usually the latest version is selected as the default language version.
The language versions can be used to mark rules to be useful only for a specific language version via
the minimumLanguageVersion
and maximumLanguageVersion
attributes. While this feature is currently only used by
the Java module, listing all possible versions enables other languages as well to use this feature.
Related issue: [core] Explicitly name all language versions (#4120)
Changed: Rule properties
- The old deprecated classes like
IntProperty
andStringProperty
have been removed. Please usePropertyFactory
to create properties. - All properties which accept multiple values now use a comma (
,
) as a delimiter. The previous default was a pipe character (|
). The delimiter is not configurable anymore. If needed, the comma can be escaped with a backslash. - The
min
andmax
attributes in property definitions in the XML are now optional and can appear separately or be omitted.
Changed: Velocity Template Language (VTL)
The module was named just “vm” which was not a good name. Its module name, language id and package names have been renamed to “velocity”.
If you import rules, you also need to adjust the paths, e.g.
category/vm/...
➡️category/velocity/...
Changed: Visualforce
There was an inconsistency between the naming of the maven module and the language id. The language id used the abbreviation “vf”, while the maven module used the longer name “visualforce”. This has been solved by renaming the language module to its full name “visualforce”. The java packages have been renamed as well.
If you import rules, you also need to adjust the paths, e.g.
category/vf/security.xml
➡️category/visualforce/security.xml
🌟 New and changed rules
New Rules
Apex
OperationWithHighCostInLoop
finds Schema class methods called in a loop, which is a potential performance issue.UnusedMethod
finds unused methods in your code.
Java
UnnecessaryBoxing
reports boxing and unboxing conversions that may be made implicit.UseExplicitTypes
reports usages ofvar
keyword, which was introduced with Java 10.
Kotlin
FunctionNameTooShort
finds functions with a too short name.OverrideBothEqualsAndHashcode
finds classes with only eitherequals
orhashCode
overridden, but not both. This leads to unexpected behavior once instances of such classes are used in collections (Lists, HashMaps, …).
Swift
ForceCast
flags all force casts, making sure you are defensively considering all types. Having the application crash shouldn’t be an option.ForceTry
flags all force tries, making sure you are defensively handling exceptions. Having the application crash shouldn’t be an option.ProhibitedInterfaceBuilder
flags any usage of interface builder. Interface builder files are prone to merge conflicts, and are impossible to code review, so larger teams usually try to avoid it or reduce its usage.UnavailableFunction
flags any function throwing afatalError
not marked as@available(*, unavailable)
to ensure no calls are actually performed in the codebase.
XML
MissingEncoding
finds XML files without explicit encoding.
Changed Rules
General changes
- All statistical rules (like ExcessiveClassLength, ExcessiveParameterList) have been simplified and unified.
The properties
topscore
andsigma
have been removed. The propertyminimum
is still there, however the type is not a decimal number anymore but has been changed to an integer. This affects rules in the languages Apex, Java, PLSQL and Velocity Template Language (velocity):- Apex:
ExcessiveClassLength
,ExcessiveParameterList
,ExcessivePublicCount
,NcssConstructorCount
,NcssMethodCount
,NcssTypeCount
- Java:
ExcessiveImports
,ExcessiveParameterList
,ExcessivePublicCount
,SwitchDensity
- PLSQL:
ExcessiveMethodLength
,ExcessiveObjectLength
,ExcessivePackageBodyLength
,ExcessivePackageSpecificationLength
,ExcessiveParameterList
,ExcessiveTypeLength
,NcssMethodCount
,NcssObjectCount
,NPathComplexity
- Velocity:
ExcessiveTemplateLength
- Apex:
- The general property
violationSuppressXPath
which is available for all rules to suppress warnings now uses XPath version 3.1 by default. This version of the XPath language is mostly identical to XPath 2.0. In PMD 6, XPath 1.0 has been used. If you upgrade from PMD 6, you need to verify yourviolationSuppressXPath
properties.
Apex General changes
- The properties
cc_categories
,cc_remediation_points_multiplier
,cc_block_highlighting
have been removed from all rules. These properties have been deprecated since PMD 6.13.0. See issue #1648 for more details.
Apex Codestyle
MethodNamingConventions
: The deprecated rule propertyskipTestMethodUnderscores
has been removed. It was actually deprecated since PMD 6.15.0, but was not mentioned in the release notes back then. Use the propertytestPattern
instead to configure valid names for test methods.
Java General changes
-
Violations reported on methods or classes previously reported the line range of the entire method or class. With PMD 7.0.0, the reported location is now just the identifier of the method or class. This affects various rules, e.g.
CognitiveComplexity
.The report location is controlled by the overrides of the method
Node#getReportLocation
in different node types.See issue #4439 and issue #730 for more details.
Java Best Practices
ArrayIsStoredDirectly
: Violations are now reported on the assignment and not anymore on the formal parameter. The reported line numbers will probably move.AvoidReassigningLoopVariables
: This rule might not report anymore all reassignments of the control variable in for-loops when the propertyforReassign
is set toskip
. See issue #4500 for more details.LooseCoupling
: The rule has a new property to allow some types to be coupled to (allowedTypes
).UnusedLocalVariable
: This rule has some important false-negatives fixed and finds many more cases now. For details see issues #2130, #4516, and #4517.
Java Codestyle
MethodNamingConventions
: The propertycheckNativeMethods
has been removed. The property was deprecated since PMD 6.3.0. Use the propertynativePattern
to control whether native methods should be considered or not.ShortVariable
: This rule now also reports short enum constant names.UseDiamondOperator
: The propertyjava7Compatibility
has been removed. The rule now handles Java 7 properly without a property.UnnecessaryFullyQualifiedName
: The rule has two new properties, to selectively disable reporting on static field and method qualifiers. The rule also has been improved to be more precise.UselessParentheses
: The rule has two new properties which control how strict the rule should be applied. WithignoreClarifying
(default: true) parentheses that are strictly speaking not necessary are allowed, if they separate expressions of different precedence. The other propertyignoreBalancing
(default: true) is similar, in that it allows parentheses that help reading and understanding the expressions.EmptyControlStatement
: The rule has a new property to allow empty blocks when they contain a comment (allowCommentedBlocks
).
Java Design
CyclomaticComplexity
: The propertyreportLevel
has been removed. The property was deprecated since PMD 6.0.0. The report level can now be configured separated for classes and methods usingclassReportLevel
andmethodReportLevel
instead.ImmutableField
: The propertyignoredAnnotations
has been removed. The property was deprecated since PMD 6.52.0.LawOfDemeter
: The rule has a new propertytrustRadius
. This defines the maximum degree of trusted data. The default of 1 is the most restrictive.NPathComplexity
: The propertyminimum
has been removed. It was deprecated since PMD 6.0.0. Use the propertyreportLevel
instead.SingularField
: The propertiescheckInnerClasses
anddisallowNotAssignment
have been removed. The rule is now more precise and will check these cases properly.UseUtilityClass
: The propertyignoredAnnotations
has been removed.
Java Documentation
CommentContent
: The propertiescaseSensitive
anddisallowedTerms
are removed. The new propertyforbiddenRegex
can be used now to define the disallowed terms with a single regular expression.CommentRequired
:- Overridden methods are now detected even without the
@Override
annotation. This is relevant for the propertymethodWithOverrideCommentRequirement
. See also pull request #3757. - Elements in annotation types are now detected as well. This might lead to an increased number of violations for missing public method comments.
- The deprecated property
headerCommentRequirement
has been removed. Use the propertyclassCommentRequirement
instead.
- Overridden methods are now detected even without the
CommentSize
: When determining the line-length of a comment, the leading comment prefix markers (e.g.*
or//
) are ignored and don’t add up to the line-length. See also pull request #4369.
Java Error Prone
AvoidDuplicateLiterals
: The propertyexceptionfile
has been removed. The property was deprecated since PMD 6.10.0. Use the propertyexceptionList
instead.DontImportSun
:sun.misc.Signal
is not special-cased anymore.EmptyCatchBlock
:CloneNotSupportedException
andInterruptedException
are not special-cased anymore. Rename the exception parameter toignored
to ignore them.ImplicitSwitchFallThrough
: Violations are now reported on the case statements rather than on the switch statements. This is more accurate but might result in more violations now.NonSerializableClass
: The deprecated propertyprefix
has been removed without replacement. In a serializable class all fields have to be serializable regardless of the name.
Deprecated Rules
In PMD 7.0.0, there are no deprecated rules.
Removed Rules
The following previously deprecated rules have been finally removed:
Apex
- performance.xml/AvoidSoqlInLoops (deleted) ➡️ use
OperationWithLimitsInLoop
- performance.xml/AvoidSoslInLoops (deleted) ➡️ use
OperationWithLimitsInLoop
- performance.xml/AvoidDmlStatementsInLoops (deleted) ➡️ use
OperationWithLimitsInLoop
- codestyle.xml/VariableNamingConventions (deleted) ➡️ use
FieldNamingConventions
,FormalParameterNamingConventions
,LocalVariableNamingConventions
, orPropertyNamingConventions
- security.xml/ApexCSRF (deleted) ➡️ use
ApexCSRF
Java
- codestyle.xml/AbstractNaming (deleted) ➡️ use
ClassNamingConventions
- codestyle.xml/AvoidFinalLocalVariable (deleted) ➡️ not replaced
- codestyle.xml/AvoidPrefixingMethodParameters (deleted) ➡️ use
FormalParameterNamingConventions
- performance.xml/AvoidUsingShortType (deleted) ➡️ not replaced
- errorprone.xml/BadComparison (deleted) ➡️ use
ComparisonWithNaN
- errorprone.xml/BeanMembersShouldSerialize (deleted) ➡️ use
NonSerializableClass
- performance.xml/BooleanInstantiation (deleted) ➡️ use
UnnecessaryBoxing
andPrimitiveWrapperInstantiation
- performance.xml/ByteInstantiation (deleted) ➡️ use
UnnecessaryBoxing
andPrimitiveWrapperInstantiation
- errorprone.xml/CloneThrowsCloneNotSupportedException (deleted) ➡️ not replaced
- errorprone.xml/DataflowAnomalyAnalysis (deleted) ➡️ use
UnusedAssignment
- codestyle.xml/DefaultPackage (deleted) ➡️ use
CommentDefaultAccessModifier
- errorprone.xml/DoNotCallSystemExit (deleted) ➡️ use
DoNotTerminateVM
- codestyle.xml/DontImportJavaLang (deleted) ➡️ use
UnnecessaryImport
- codestyle.xml/DuplicateImports (deleted) ➡️ use
UnnecessaryImport
- errorprone.xml/EmptyFinallyBlock (deleted) ➡️ use
EmptyControlStatement
- errorprone.xml/EmptyIfStmt (deleted) ➡️ use
EmptyControlStatement
- errorprone.xml/EmptyInitializer (deleted) ➡️ use
EmptyControlStatement
- errorprone.xml/EmptyStatementBlock (deleted) ➡️ use
EmptyControlStatement
- errorprone.xml/EmptyStatementNotInLoop (deleted) ➡️ use
UnnecessarySemicolon
- errorprone.xml/EmptySwitchStatements (deleted) ➡️ use
EmptyControlStatement
- errorprone.xml/EmptySynchronizedBlock (deleted) ➡️ use
EmptyControlStatement
- errorprone.xml/EmptyTryBlock (deleted) ➡️ use
EmptyControlStatement
- errorprone.xml/EmptyWhileStmt (deleted) ➡️ use
EmptyControlStatement
- design.xml/ExcessiveClassLength (deleted) ➡️ use
NcssCount
- design.xml/ExcessiveMethodLength (deleted) ➡️ use
NcssCount
- codestyle.xml/ForLoopsMustUseBraces (deleted) ➡️ use
ControlStatementBraces
- codestyle.xml/IfElseStmtsMustUseBraces (deleted) ➡️ use
ControlStatementBraces
- codestyle.xml/IfStmtsMustUseBraces (deleted) ➡️ use
ControlStatementBraces
- errorprone.xml/ImportFromSamePackage (deleted) ➡️ use
UnnecessaryImport
- performance.xml/IntegerInstantiation (deleted) ➡️ use
UnnecessaryBoxing
andPrimitiveWrapperInstantiation
- errorprone.xml/InvalidSlf4jMessageFormat (deleted) ➡️ use
InvalidLogMessageFormat
- errorprone.xml/LoggerIsNotStaticFinal (deleted) ➡️ use
ProperLogger
- performance.xml/LongInstantiation (deleted) ➡️ use
UnnecessaryBoxing
andPrimitiveWrapperInstantiation
- codestyle.xml/MIsLeadingVariableName (deleted) ➡️ use
FieldNamingConventions
,FormalParameterNamingConventions
, orLocalVariableNamingConventions
- errorprone.xml/MissingBreakInSwitch (deleted) ➡️ use
ImplicitSwitchFallThrough
- design.xml/ModifiedCyclomaticComplexity (deleted) ➡️ use
CyclomaticComplexity
- design.xml/NcssConstructorCount (deleted) ➡️ use
NcssCount
- design.xml/NcssMethodCount (deleted) ➡️ use
NcssCount
- design.xml/NcssTypeCount (deleted) ➡️ use
NcssCount
- bestpractices.xml/PositionLiteralsFirstInCaseInsensitiveComparisons (deleted) ➡️
use
LiteralsFirstInComparisons
- bestpractices.xml/PositionLiteralsFirstInComparisons (deleted) ➡️
use
LiteralsFirstInComparisons
- errorprone.xml/ReturnEmptyArrayRatherThanNull (deleted) ➡️
use
ReturnEmptyCollectionRatherThanNull
- performance.xml/ShortInstantiation (deleted) ➡️ use
UnnecessaryBoxing
andPrimitiveWrapperInstantiation
- design.xml/SimplifyBooleanAssertion (deleted) ➡️ use
SimplifiableTestAssertion
- performance.xml/SimplifyStartsWith (deleted) ➡️ not replaced
- design.xml/StdCyclomaticComplexity (deleted) ➡️ use
CyclomaticComplexity
- codestyle.xml/SuspiciousConstantFieldName (deleted) ➡️ use
FieldNamingConventions
- performance.xml/UnnecessaryWrapperObjectCreation (deleted) ➡️ use the new rule
UnnecessaryBoxing
- multithreading.xml/UnsynchronizedStaticDateFormatter (deleted) ➡️ use
UnsynchronizedStaticFormatter
- bestpractices.xml/UnusedImports (deleted) ➡️ use
UnnecessaryImport
- bestpractices.xml/UseAssertEqualsInsteadOfAssertTrue (deleted) ➡️ use
SimplifiableTestAssertion
- bestpractices.xml/UseAssertNullInsteadOfAssertEquals (deleted) ➡️ use
SimplifiableTestAssertion
- bestpractices.xml/UseAssertSameInsteadOfAssertEquals (deleted) ➡️ use
SimplifiableTestAssertion
- bestpractices.xml/UseAssertTrueInsteadOfAssertEquals (deleted) ➡️ use
SimplifiableTestAssertion
- codestyle.xml/VariableNamingConventions (deleted) ➡️ use
FieldNamingConventions
,FormalParameterNamingConventions
, orLocalVariableNamingConventions
- codestyle.xml/WhileLoopsMustUseBraces (deleted) ➡️ use
ControlStatementBraces
Removed rulesets
The following previously deprecated rulesets have been removed. These were the left-over rulesets from PMD 5. The rules have been moved into categories with PMD 6.
- rulesets/apex/apexunit.xml
- rulesets/apex/braces.xml
- rulesets/apex/complexity.xml
- rulesets/apex/empty.xml
- rulesets/apex/metrics.xml
- rulesets/apex/performance.xml
- rulesets/apex/ruleset.xml
- rulesets/apex/securty.xml
- rulesets/apex/style.xml
- rulesets/java/android.xml
- rulesets/java/basic.xml
- rulesets/java/clone.xml
- rulesets/java/codesize.xml
- rulesets/java/comments.xml
- rulesets/java/controversial.xml
- rulesets/java/coupling.xml
- rulesets/java/design.xml
- rulesets/java/empty.xml
- rulesets/java/finalizers.xml
- rulesets/java/imports.xml
- rulesets/java/j2ee.xml
- rulesets/java/javabeans.xml
- rulesets/java/junit.xml
- rulesets/java/logging-jakarta-commons.xml
- rulesets/java/logging-java.xml
- rulesets/java/metrics.xml
- rulesets/java/migrating.xml
- rulesets/java/migrating_to_13.xml
- rulesets/java/migrating_to_14.xml
- rulesets/java/migrating_to_15.xml
- rulesets/java/migrating_to_junit4.xml
- rulesets/java/naming.xml
- rulesets/java/optimizations.xml
- rulesets/java/strictexception.xml
- rulesets/java/strings.xml
- rulesets/java/sunsecure.xml
- rulesets/java/typeresolution.xml
- rulesets/java/unnecessary.xml
- rulesets/java/unusedcode.xml
- rulesets/ecmascript/basic.xml
- rulesets/ecmascript/braces.xml
- rulesets/ecmascript/controversial.xml
- rulesets/ecmascript/unnecessary.xml
- rulesets/jsp/basic.xml
- rulesets/jsp/basic-jsf.xml
- rulesets/plsql/codesize.xml
- rulesets/plsql/dates.xml
- rulesets/plsql/strictsyntax.xml
- rulesets/plsql/TomKytesDespair.xml
- rulesets/vf/security.xml
- rulesets/vm/basic.xml
- rulesets/pom/basic.xml
- rulesets/xml/basic.xml
- rulesets/xsl/xpath.xml
- rulesets/releases/*
💥 Compatibility and Migration Notes
Note: The full detailed documentation of the changes are available in the Migration Guide for PMD 7
For endusers
- PMD 7 requires Java 8 or above to execute.
- CLI changed: Custom scripts need to be updated (
run.sh pmd ...
➡️pmd check ...
,run.sh cpd ...
➡️pmd cpd ...
). - Java module revamped: Custom rules need to be updated.
- Removed rules: Custom rulesets need to be reviewed. See above for a list of new and removed rules.
- XPath 1.0 and 2.0 support is removed,
violationSuppressXPath
now requires XPath 3.1: Custom rulesets need to be reviewed. - Custom rules using rulechains: Need to override
AbstractRule#buildTargetSelector
usingRuleTargetSelector#forTypes
. -
The asset filenames of PMD on GitHub Releases are now
pmd-dist-<version>-bin.zip
,pmd-dist-<version>-src.zip
andpmd-dist-<version>-doc.zip
. Keep that in mind, if you have an automated download script.The structure inside the ZIP files stay the same, e.g. we still provide inside the binary distribution ZIP file the base directory
pmd-bin-<version>
. - For maven-pmd-plugin usage, see Using PMD 7 with maven-pmd-plugin.
- For gradle users, at least gradle 8.6 is required for PMD 7.
For integrators
- PMD 7 is a major release where many things have been moved or rewritten.
- All integrators will require some level of change to adapt to the change in the API.
- For more details look at the deprecations notes of the past PMD 6 releases. These are collected below under API Changes.
- The PMD Ant tasks, which were previously in the module
pmd-core
has been moved into its own modulepmd-ant
, which needs to be added explicitly now as an additional dependency. - The CLI classes have also been moved out of
pmd-core
into its own modulepmd-cli
. The old entry point, the main classPMD
is gone.
🚨 API
The API of PMD has been growing over the years and needed some cleanup. The goal is, to have a clear separation between a well-defined API and the implementation, which is internal. This should help us in future development.
This however entails some incompatibilities and deprecations.
See ADR 3 - API evolution principles and API changes below.
Small Changes and cleanups
-
#1648: [apex,vf] Remove CodeClimate dependency - Robert Sösemann Properties “cc_categories”, “cc_remediation_points_multiplier”, “cc_block_highlighting” can no longer be overridden in rulesets. They were deprecated without replacement.
-
The old GUI applications accessible through
run.sh designerold
andrun.sh bgastviewer
(and corresponding Batch scripts) have been removed from the PMD distribution. Please use the newer rule designer withpmd designer
. The corresponding classes in packagesjava.net.sourceforge.pmd.util.viewer
andjava.net.sourceforge.pmd.util.designer
have all been removed. -
All API related to XPath support has been moved to the package
net.sourceforge.pmd.lang.rule.xpath
. This includes API that was previously dispersed overnet.sourceforge.pmd.lang
,net.sourceforge.pmd.lang.ast.xpath
,net.sourceforge.pmd.lang.rule.xpath
,net.sourceforge.pmd.lang.rule
, and various language-specific packages (which were made internal). -
The implementation of the Ant integration has been moved from the module
pmd-core
to a new modulepmd-ant
. This involves classes in packagenet.sourceforge.pmd.ant
. The ant CPDTask classnet.sourceforge.pmd.cpd.CPDTask
has been moved into the same packagenet.sourceforge.pmd.ant
. You’ll need to update your taskdef entries in your build.xml files with the FQCNnet.sourceforge.pmd.ant.CPDTask
if you use it anywhere. -
Utility classes in
net.sourceforge.pmd.util
, that have previously marked as@InternalApi
have been finally moved to an internal sub package and are now longer available. This includes ClasspathClassLoader, FileFinder, FileUtil, and IOUtil. - The following utility classes in
net.sourceforge.pmd.util
are now considered public API: - Moved the two classes
AntlrCpdLexer
andJavaccCpdLexer
frominternal
package into packagenet.sourceforge.pmd.cpd.impl
. These two classes are part of the API and are base classes for CPD language implementations. Since 7.0.0-rc2. Note: These two classes have been previously called “AntlrTokenizer” and “JavaCCTokenizer”. AntlrBaseRule
is gone in favor ofAbstractVisitorRule
. Since 7.0.0-rc2.- The classes
net.sourceforge.pmd.lang.kotlin.ast.KotlinInnerNode
andnet.sourceforge.pmd.lang.swift.ast.SwiftInnerNode
are package-private now. Since 7.0.0-rc2.
XPath 3.1 support
Support for XPath versions 1.0, 1.0-compatibility, 2.0 was removed. The default (and only) supported XPath version is now XPath 3.1. This version of the XPath language is mostly identical to XPath 2.0.
Notable changes:
- The deprecated support for sequence-valued attributes is removed. Sequence-valued properties are still supported.
- Refer to the Saxonica documentation for an introduction to new features in XPath 3.1.
Node stream API for AST traversal
This version includes a powerful API to navigate trees, similar in usage to the Java 8 Stream API:
node.descendants(ASTMethodCall.class)
.filter(m -> "toString".equals(m.getMethodName()))
.map(m -> m.getQualifier())
.filter(q -> TypeTestUtil.isA(String.class, q))
.foreach(System.out::println);
A pipeline like shown here traverses the tree lazily, which is more efficient than traversing eagerly to put all descendants in a list. It is also much easier to change than the old imperative way.
To make this API as accessible as possible, the Node
interface has been fitted with new
methods producing node streams. Those methods replace previous tree traversal methods like Node#findDescendantsOfType
.
In all cases, they should be more efficient and more convenient.
See NodeStream
for more details.
Contributors: Clément Fournier (@oowekyala)
Metrics framework
The metrics framework has been made simpler and more general.
-
The metric interface takes an additional type parameter, representing the result type of the metric. This is usually
Integer
orDouble
. It avoids widening the result to adouble
just to narrow it down.This makes it so, that
Double.NaN
is not an appropriate sentinel value to represent “not supported” anymore. Instead,computeFor
may returnnull
in that case (or a garbage value). The valuenull
may have caused problems with the narrowing casts, which through unboxing, might have thrown an NPE. But when we deprecated the language-specific metrics façades to replace them with the genericMetricsUtil
, we took care of making the new methods throw an exception if the metric cannot be computed on the parameter. This forces you to guard calls toMetricsUtil#computeMetric
(and other overloads) with something likeif (metric.supports(node))
. If you’re following this pattern, then you won’t observe the undefined behavior. -
The
MetricKey
interface is not so useful and has been merged into theMetric
interface and removed. So theMetric
interface has the new methoddisplayName
. -
The framework is not tied to at most 2 node types per language anymore. Previously those were nodes for classes and for methods/constructors. Instead, many metrics support more node types. For example, NCSS can be computed on any code block.
For that reason, keeping around a hard distinction between “class metrics” and “operation metrics” is not useful. So in the Java framework for example, we removed the interfaces
JavaClassMetric
,JavaOperationMetric
, abstract classes for those,JavaClassMetricKey
, andJavaOperationMetricKey
. Metric constants are now all inside theJavaMetrics
utility class. The same was done in the Apex framework.We don’t really need abstract classes for metrics now. So
AbstractMetric
is also removed from pmd-core. There is a factory method on theMetric
interface to create a metric easily. -
This makes it so, that
LanguageMetricsProvider
does not need type parameters. It can just return aSet<Metric<?, ?>>
to list available metrics. -
Signature
s, their implementations, and the interfaceSignedNode
have been removed. Node streams allow replacing their usages very easily.
Testing framework
- PMD 7 has been upgraded to use JUnit 5 only. That means, that JUnit4 related classes have been removed, namely
net.sourceforge.pmd.testframework.PMDTestRunner
net.sourceforge.pmd.testframework.RuleTestRunner
net.sourceforge.pmd.testframework.TestDescriptor
- Rule tests, that use
SimpleAggregatorTst
orPmdRuleTst
work as before without change, but use now JUnit5 under the hood. If you added additional JUnit4 tests to your rule test classes, then you’ll need to upgrade them to use JUnit5.
Language Lifecycle and Language Properties
- Language modules now provide a proper lifecycle and can store global information. This enables the implementation of multifile analysis.
- Language modules can define custom language properties which can be set via environment variables. This allows to add and use language specific configuration options without the need to change pmd-core.
The documentation page has been updated: Adding a new language with JavaCC and Adding a new language with ANTLR
Related issue: [core] Language lifecycle (#3782)
Rule properties
- The old deprecated classes like
IntProperty
andStringProperty
have been removed. Please usePropertyFactory
to create properties. - All properties which accept multiple values now use a comma (
,
) as a delimiter. The previous default was a pipe character (|
). The delimiter is not configurable anymore. If needed, the comma can be escaped with a backslash. - The
min
andmax
attributes in property definitions in the XML are now optional and can appear separately or be omitted.
New Programmatic API for CPD
This release introduces a new programmatic API to replace the old class CPD
. The new API uses a similar model to
PmdAnalysis
and is called CpdAnalysis
. Programmatic execution of CPD should now be
done with a CPDConfiguration
and a CpdAnalysis
, for instance:
CPDConfiguration config = new CPDConfiguration();
config.setMinimumTileSize(100);
config.setOnlyRecognizeLanguage(config.getLanguageRegistry().getLanguageById("java"));
config.setSourceEncoding(StandardCharsets.UTF_8);
config.addInputPath(Path.of("src/main/java")
config.setIgnoreAnnotations(true);
config.setIgnoreLiterals(false);
config.setRendererName("text");
try (CpdAnalysis cpd = CpdAnalysis.create(config)) {
// note: don't use `config` once a CpdAnalysis has been created.
// optional: add more files
cpd.files().addFile(Paths.get("src", "main", "more-java", "ExtraSource.java"));
cpd.performAnalysis();
}
CPD can of course still be called via command line or using the module pmd-cli
. But for tight integration
this new programmatic API is recommended.
See PR #4397 for details.
API changes
7.0.0
These are the changes between 7.0.0-rc4 and final 7.0.0.
pmd-java
- Support for Java 20 preview language features have been removed. The version “20-preview” is no longer available.
ASTPattern
,ASTRecordPattern
,ASTTypePattern
,ASTUnnamedPattern
- method
getParenthesisDepth()
has been removed.
- method
ASTTemplateFragment
: To get the content of the template, use nowgetContent
or@Content
instead ofgetImage()
/@Image
.ASTUnnamedPattern
is not experimental anymore. The language feature has been standardized with Java 22.
New API
The API around TreeRenderer
has been declared as stable. It was previously
experimental. It can be used via the CLI subcommand ast-dump
or programmatically, as described
on Creating XML dump of the AST.
General AST Changes to avoid @Image
See General AST Changes to avoid @Image in the migration guide for details.
XPath Rules
- The property
version
was already deprecated and has finally been removed. Please don’t define the version property anymore in your custom XPath rules. By default, the latest XPath version will be used, which is XPath 3.1.
Moved classes/consolidated packages
- pmd-core
- Many types have been moved from the base package
net.sourceforge.pmd
into subpackagenet.sourceforge.pmd.lang.rule
Rule
RulePriority
RuleSet
RuleSetFactory
RuleSetLoader
RuleSetLoadException
RuleSetWriter
- Many types have been moved from the base package
net.sourceforge.pmd
into subpackagenet.sourceforge.pmd.reporting
XPathRule
has been moved into subpackagenet.sourceforge.pmd.lang.rule.xpath
.
- Many types have been moved from the base package
- pmd-html
net.sourceforge.pmd.lang.html.ast.HtmlCpdLexer
moved into packagecpd
:HtmlCpdLexer
.
- pmd-lang-test: All types have been moved under the new base package
net.sourceforge.pmd.lang.test
:AbstractMetricTestRule
(moved fromnet.sourceforge.pmd.test.AbstractMetricTestRule
)BaseTextComparisonTest
(moved fromnet.sourceforge.pmd.test.BaseTextComparisonTest
)CpdTextComparisonTest
(moved fromnet.sourceforge.pmd.cpd.test.CpdTextComparisonTest
)BaseTreeDumpTest
(moved fromnet.sourceforge.pmd.lang.ast.test.BaseTreeDumpTest
)- And many other types have been moved from
net.sourceforge.pmd.lang.ast.test
tonet.sourceforge.pmd.lang.test
.
- pmd-scala
ScalaCpdLexer
(moved fromnet.sourceforge.pmd.lang.scala.cpd.ScalaCpdLexer
)ScalaTokenAdapter
(moved fromnet.sourceforge.pmd.lang.scala.cpd.ScalaTokenAdapter
)
- pmd-test
AbstractRuleSetFactoryTest
(moved fromnet.sourceforge.pmd.lang.rule.AbstractRuleSetFactoryTest
)AbstractAntTestHelper
(moved fromnet.sourceforge.pmd.ant.AbstractAntTestHelper
)AbstractLanguageVersionTest
(moved fromnet.sourceforge.pmd.AbstractLanguageVersionTest
)PmdRuleTst
(moved fromnet.sourceforge.pmd.testframework.PmdRuleTst
)RuleTst
(moved fromnet.sourceforge.pmd.testframework.RuleTst
)SimpleAggregatorTst
(moved fromnet.sourceforge.pmd.testframework.SimpleAggregatorTst
)
- pmd-xml
PomLanguageModule
(moved fromnet.sourceforge.pmd.lang.pom.PomLanguageModule
)WsdlLanguageModule
(moved fromnet.sourceforge.pmd.lang.wsdl.WsdlLanguageModule
)XslLanguageModule
(moved fromnet.sourceforge.pmd.lang.xsl.XslLanguageModule
)
- pmd-visualforce
- The package
net.sourceforge.pmd.lang.vf
has been renamed tonet.sourceforge.pmd.lang.visualforce
. - The language id of visualforce has been changed to
visualforce
(it was previously just “vf”) - The ruleset changed:
category/vf/security.xml
➡️category/visualforce/security.xml
- The package
- pmd-velocity (renamed from pmd-vm)
- The package
net.sourceforge.pmd.lang.vm
has been renamed tonet.sourceforge.pmd.lang.velocity
. - The language id of the Velocity module has been changed to
velocity
(it was previously just “vm”) - The rulesets changed:
category/vm/...
➡️category/velocity/...
- Many classes used the prefix
Vm
, e.g.VmLanguageModule
. This has been changed to beVtl
:
- The package
Internalized classes and interfaces and methods
The following classes/methods have been marked as @InternalApi before and are now moved into a internal
package or made (package) private and are not accessible anymore.
- pmd-core
net.sourceforge.pmd.cache.AbstractAnalysisCache
(moved to internal, now package private)net.sourceforge.pmd.cache.AnalysisCache
(moved to internal)net.sourceforge.pmd.cache.AnalysisCacheListener
(moved to internal)net.sourceforge.pmd.cache.AnalysisResult
(moved to internal)net.sourceforge.pmd.cache.CachedRuleMapper
(moved to internal, now package private)net.sourceforge.pmd.cache.CachedRuleViolation
(moved to internal, now package private)net.sourceforge.pmd.cache.ChecksumAware
(moved to internal)net.sourceforge.pmd.cache.FileAnalysisCache
(moved to internal)net.sourceforge.pmd.cache.NoopAnalysisCache
(moved to internal)net.sourceforge.pmd.util.ResourceLoader
(moved to internal)net.sourceforge.pmd.cpd.Tokens
- Constructor is now package private.
net.sourceforge.pmd.lang.LanguageProcessor.AnalysisTask
- Constructor is now package private.
- Method
withFiles(java.util.List)
is now package private. Note: it was not previously marked with @InternalApi.
net.sourceforge.pmd.lang.rule.RuleTargetSelector
- Method
isRuleChain()
has been removed.
- Method
net.sourceforge.pmd.renderers.AbstractAccumulatingRenderer
renderFileReport
- this method is now final and can’t be overridden anymore.
net.sourceforge.pmd.reporting.Report
- Constructor as well as the methods
addRuleViolation
,addConfigError
,addError
are now private.
- Constructor as well as the methods
net.sourceforge.pmd.reporting.RuleContext
- Method
getRule()
is now package private. - Method
create(FileAnalysisListener listener, Rule rule)
has been removed.
- Method
net.sourceforge.pmd.rules.RuleFactory
: moved into subpackagelang.rule
and made package private. It has now been hidden completely from public API.- Many types have been moved from into subpackage
lang.rule.internal
.net.sourceforge.pmd.RuleSetReference
net.sourceforge.pmd.RuleSetReferenceId
net.sourceforge.pmd.RuleSets
net.sourceforge.pmd.lang.rule.ParametricRuleViolation
is now package private and moved tonet.sourceforge.pmd.reporting.ParametricRuleViolation
. The only public API isRuleViolation
.net.sourceforge.pmd.lang.rule.RuleSet
- Method
applies(Rule,LanguageVersion)
is now package private. - Method
applies(TextFile)
has been removed. - Method
applies(FileId)
is now package private.
- Method
net.sourceforge.pmd.lang.rule.RuleSetLoader
- Method
loadRuleSetsWithoutException(java.util.List)
is now package private.
- Method
net.sourceforge.pmd.lang.rule.RuleSetLoadException
- All constructors are package private now.
net.sourceforge.pmd.lang.ast.LexException
- the constructorLexException(boolean, String, int, int, String, char)
is now package private. It is only used by JavaCC-generated token managers.net.sourceforge.pmd.PMDConfiguration
- Method
setAnalysisCache(AnalysisCache)
is now package private. UsesetAnalysisCacheLocation
instead. - Method
getAnalysisCache()
is now package private.
- Method
net.sourceforge.pmd.lang.document.FileCollector
- Method
newCollector(LanguageVersionDiscoverer, PmdReporter)
is now package private. - Method
newCollector(PmdReporter)
is now package private. - In order to create a FileCollector, use
files
instead.
- Method
net.sourceforge.pmd.lang.rule.xpath.Attribute
- Method
replacementIfDeprecated()
is now package private.
- Method
net.sourceforge.pmd.properties.PropertyTypeId
- moved in subpackageinternal
.net.sourceforge.pmd.properties.PropertyDescriptor
- methodgetTypeId()
is now package private.
- pmd-doc
- The whole maven module
pmd-doc
is now considered internal API even though it was not declared so before. It’s used to generate the rule documentation for the built-in rules. - All the classes have been moved into package
net.sourceforge.pmd.doc.internal
.
- The whole maven module
- pmd-ant
net.sourceforge.pmd.ant.Formatter
- Method
getRenderer()
has been removed. - Method
start(String)
is private now. - Method
end(Report)
has been removed. - Method
isNoOutputSupplied()
is now package private. - Method
newListener(Project)
is now package private.
- Method
net.sourceforge.pmd.ant.PMDTask
- Method
getRelativizeRoots()
has been removed.
- Method
net.sourceforge.pmd.ant.ReportException
is now package private. Note: It was not marked with @InternalApi before.
- pmd-apex
net.sourceforge.pmd.lang.apex.ast.ApexNode
- Method
getNode()
has been removed. It was only deprecated before and not marked with @InternalApi. However, it gave access to the wrapped Jorje node and was thus internal API.
- Method
net.sourceforge.pmd.lang.apex.ast.AbstractApexNode
- Method
getNode()
is now package private.
- Method
net.sourceforge.pmd.lang.apex.multifile.ApexMultifileAnalysis
- Constructor is now package private.
net.sourceforge.pmd.lang.apex.rule.design.AbstractNcssCountRule
(now package private)net.sourceforge.pmd.lang.apex.rule.AbstractApexUnitTestRule
(moved to packagenet.sourceforge.pmd.apex.rule.bestpractices
, now package private)
- pmd-java
net.sourceforge.pmd.lang.java.rule.AbstractIgnoredAnnotationRule
(moved to internal)net.sourceforge.pmd.lang.java.types.ast.LazyTypeResolver
(moved to internal)net.sourceforge.pmd.lang.java.types.JMethodSig
- Method
internalApi()
has been removed.
- Method
net.sourceforge.pmd.lang.java.types.TypeOps
- Method
isSameTypeInInference(JTypeMirror,JTypeMirror)
is now package private.
- Method
- pmd-jsp
net.sourceforge.pmd.lang.jsp.ast.JspParser
- Method
getTokenBehavior()
has been removed.
- Method
- pmd-modelica
net.sourceforge.pmd.lang.modelica.ast.InternalApiBridge
renamed fromInternalModelicaNodeApi
.net.sourceforge.pmd.lang.modelica.resolver.InternalApiBridge
renamed fromInternalModelicaResolverApi
.net.sourceforge.pmd.lang.modelica.resolver.ModelicaSymbolFacade
has been removed.net.sourceforge.pmd.lang.modelica.resolver.ResolutionContext
(moved to internal)net.sourceforge.pmd.lang.modelica.resolver.ResolutionState
(moved to internal). Note: it was not previously marked with @InternalApi.net.sourceforge.pmd.lang.modelica.resolver.Watchdog
(moved to internal). Note: it was not previously marked with @InternalApi.
- pmd-plsql
net.sourceforge.pmd.lang.plsql.rule.design.AbstractNcssCountRule
is now package private.
- pmd-scala
net.sourceforge.pmd.lang.scala.ScalaLanguageModule
- Method
dialectOf(LanguageVersion)
has been removed.
- Method
Removed classes and members (previously deprecated)
The annotation @DeprecatedUntil700
has been removed.
- pmd-core
CpdLanguageProperties
. The fieldDEFAULT_SKIP_BLOCKS_PATTERN
has been removed.BaseAntlrNode
- methodjoinTokenText()
has been removed.Node
- many methods have been removed:getNthParent(int)
- Useancestors
instead, e.g.node.ancestors().get(n-1)
getFirstParentOfType(Class)
- Useancestors
instead, e.g.node.ancestors(parentType).first()
getParentsOfType(Class)
- Useancestors
instead, e.g.node.ancestors(parentType).toList()
findChildrenOfType(Class)
- Usechildren
instead, e.g.node.children(childType).toList()
findDescendantsOfType(Class)
- Usedescendants
instead, e.g.node.descendants(targetType).toList()
findDescendantsOfType(Class,boolean)
- Usedescendants
instead, e.g.node.descendants(targetType).crossFindBoundaries(b).toList()
getFirstChildOfType(Class)
- UsefirstChild
insteadgetFirstDescendantOfType(Class)
- Usedescendants
instead, e.g.node.descendants(targetType).first()
hasDescendantOfType(Class)
- Usedescendants
instead, e.g.node.descendants(targetType).nonEmpty()
findChildNodesWithXPath(String)
- Use theNodeStream
API instead.
GenericNode
- methodgetNthParent(int)
has been removed. Useancestors
instead, e.g.node.ancestors().get(n-1)
FileCollector
- methodaddZipFile(java.nio.file.Path)
has been removed. UseaddZipFileWithContent
insteadTextDocument
- methodreadOnlyString(CharSequence,String,LanguageVersion)
has been removed. UsereadOnlyString
instead.TextFile
- methoddataSourceCompat(DataSource,PMDConfiguration)
has been removed. UseTextFile
directly, e.g.forPath
XPathVersion
XPATH_1_0
XPATH_1_0_COMPATIBILITY
XPATH_2_0
- Only XPath version 3.1 is now supported. This version of the XPath language is mostly identical to
XPath 2.0. XPath rules by default use now
XPATH_3_1
.
net.sourceforge.pmd.lang.rule.AbstractDelegateRule
removed. It has been merged withRuleReference
.AbstractRule
- the following methods have been removed:deepCopyValuesTo(AbstractRule)
- usedeepCopy
instead.addRuleChainVisit(Class)
- overridebuildTargetSelector
in order to register nodes for rule chain visits.addViolation(...)
- useaddViolation
instead, e.g. viaasCtx(data).addViolation(...)
. Note: These methods were only marked as deprecated in javadoc.addViolationWithMessage(...)
- useaddViolationWithMessage
instead, e.g. viaasCtx(data).addViolationWithMessage(...)
. Note: These methods were only marked as deprecated in javadoc.
RuleReference
- the following methods have been removed:setRuleSetReference(RuleSetReference)
- without replacement. Just construct newRuleReference
instead.hasOverriddenProperty(PropertyDescriptor)
- useisPropertyOverridden
instead.
XPathRule
- The constant
XPATH_DESCRIPTOR
has been made private and is not accessible anymore. - The default constructor has been made package-private and is not accessible anymore.
- The constant
Language
- methodgetTerseName()
removed. UsegetId
instead.LanguageModuleBase
- methodgetTerseName()
removed. UsegetId
instead.LanguageRegistry
- the following methods have been removed:getLanguage(String)
- usegetLanguageByFullName
viaPMD
orCPD
instead.findLanguageByTerseName(String)
- usegetLanguageById
viaPMD
orCPD
instead.findByExtension(String)
- removed without replacement.
LanguageVersionDiscoverer
- methodgetLanguagesForFile(java.io.File)
removed. UsegetLanguagesForFile
instead.AbstractPropertySource
- field
propertyDescriptors
has been made private and is not accessible anymore. UsegetPropertyDescriptors
instead. - field
propertyValuesByDescriptor
has been made private and is not accessible anymore. UsegetPropertiesByPropertyDescriptor
orgetOverriddenPropertiesByPropertyDescriptor
instead. - method
copyPropertyDescriptors()
has been removed. UsegetPropertyDescriptors
instead. - method
copyPropertyValues()
has been removed. UsegetPropertiesByPropertyDescriptor
orgetOverriddenPropertiesByPropertyDescriptor
instead.
- field
Reportable
- the following methods have been removed. UsegetReportLocation
insteadgetBeginLine()
getBeginColumn()
getEndLine()
getEndColumn()
net.sourceforge.pmd.util.datasource.DataSource
- useTextFile
instead.net.sourceforge.pmd.util.datasource.FileDataSource
net.sourceforge.pmd.util.datasource.ReaderDataSource
net.sourceforge.pmd.util.datasource.ZipDataSource
CollectionUtil
- method
invertedMapFrom(...)
has been removed. - method
mapFrom(...)
has been removed.
- method
AbstractConfiguration
- the following methods have been removed:setIgnoreFilePath(String)
- usesetIgnoreFilePath
instead.setInputFilePath(String)
- usesetInputFilePath
instead.setInputPaths(String)
- usesetInputPathList
oraddInputPath
instead.setInputUri(String)
- usesetInputUri
instead.
PMDConfiguration
- the following methods have been removedprependClasspath(String)
- useprependAuxClasspath
instead.getRuleSets()
- usegetRuleSetPaths
instead.setRuleSets(String)
- usesetRuleSets
oraddRuleSet
instead.setReportFile(String)
- usesetReportFile
instead.getReportFile()
- usegetReportFilePath
instead.
Report
- methodmerge(Report)
has been removed. Useunion
instead.RuleSetLoader
- methodtoFactory()
has been made package private and is not accessible anymore.RuleViolation
- the following methods have been removed:getPackageName()
- usegetAdditionalInfo
withPACKAGE_NAME
instead, e.g.getAdditionalInfo().get(PACKAGE_NAME)
.getClassName()
- usegetAdditionalInfo
withCLASS_NAME
instead, e.g.getAdditionalInfo().get(CLASS_NAME)
.getMethodName()
- usegetAdditionalInfo
withMETHOD_NAME
instead, e.g.getAdditionalInfo().get(METHOD_NAME)
.getVariableName()
- usegetAdditionalInfo
withVARIABLE_NAME
instead, e.g.getAdditionalInfo().get(VARIABLE_NAME)
.
- pmd-apex
ApexNode
andASTApexFile
-
#getApexVersion()
: In PMD 6, this method has been deprecated but was defined in the classApexRootNode
. The version returned is always “Version.CURRENT”, as the apex compiler integration doesn’t use additional information which Apex version actually is used. Therefore, this method can’t be used to determine the Apex version of the project that is being analyzed.If the current version is needed, then
Node.getTextDocument().getLanguageVersion()
can be used. This is the version that has been selected via CLI--use-version
parameter.
-
ApexNode
- method
jjtAccept()
has been removed. UseacceptVisitor
instead. - method
getNode()
has been removed. The underlying node is only available in AST nodes, but not in rule implementations.
- method
AbstractApexNode
- methodgetNode()
is now package private. AST nodes still have access to the underlying Jorje node via the protected propertynode
.net.sourceforge.pmd.lang.apex.ast.ApexParserVisitor
UseApexVisitor
orApexVisitorBase
instead.net.sourceforge.pmd.lang.apex.ast.ApexParserVisitorAdapter
ASTAssignmentExpression
- methodgetOperator()
removed. UsegetOp
instead.ASTBinaryExpression
- methodgetOperator()
removed. UsegetOp
instead.ASTBooleanExpression
- methodgetOperator()
removed. UsegetOp
instead.ASTPostfixExpression
- methodgetOperator()
removed. UsegetOp
instead.ASTPrefixExpression
- methodgetOperator()
removed. UsegetOp
instead.net.sourceforge.pmd.lang.apex.rule.security.Helper
removed. This was actually internal API.
- pmd-java
AbstractPackageNameModuleDirective
- methodgetImage()
has been removed. UsegetPackageName
instead.AbstractTypeDeclaration
- methodgetImage()
has been removed. UsegetSimpleName()
instead.ASTAnnotation
- methodgetAnnotationName()
has been removed.ASTClassType
- constructor
ASTClassType(java.lang.String)
has been removed. - method
getImage()
has been removed. - method
isReferenceToClassSameCompilationUnit()
has been removed.
- constructor
ASTFieldDeclaration
- methodgetVariableName()
has been removed.ASTLiteral
- the following methods have been removed:isStringLiteral()
- usenode instanceof ASTStringLiteral
instead.isCharLiteral()
- usenode instanceof ASTCharLiteral
instead.isNullLiteral()
- usenode instanceof ASTNullLiteral
instead.isBooleanLiteral()
- usenode instanceof ASTBooleanLiteral
instead.isNumericLiteral()
- usenode instanceof ASTNumericLiteral
instead.isIntLiteral()
- useisIntLiteral
instead.isLongLiteral()
- useisLongLiteral
instead.isFloatLiteral()
- useisFloatLiteral
instead.isDoubleLiteral()
- useisDoubleLiteral
instead.
ASTMethodDeclaration
- methodsgetImage()
andgetMethodName()
have been removed. UsegetName
instead.ASTMethodReference
- methodgetImage()
has been removed.ASTModuleName
- methodgetImage()
has been removed.ASTPrimitiveType
- methodgetImage()
has been removed.ASTType
getTypeImage()
has been removed.getArrayDepth()
has been removed. It’s only available for arrays:getArrayDepth
.isPrimitiveType()
- usenode instanceof ASTPrimitiveType
instead.isArrayType()
- usenode instanceof ASTArrayType
instead.isClassOrInterfaceType()
- usenode instanceof ASTClassType
instead.
ASTTypeDeclaration
- methodgetImage()
has been removed.ASTUnaryExpression
- methodisPrefix()
has been removed. UsegetOperator
.isPrefix()
instead.ASTVariableId
- methodsgetImage()
andgetVariableName()
have been removed. UsegetName
instead.JavaComment
- methodgetImage()
has been removed. UsegetText
instead.JavaNode
- methodjjtAccept()
has been removed. UseacceptVisitor
instead.net.sourceforge.pmd.lang.java.ast.JavaParserVisitor
UseJavaVisitor
orJavaVisitorBase
instead.net.sourceforge.pmd.lang.java.ast.JavaParserVisitorAdapter
ModifierOwner
isFinal()
- This is still available in various subtypes, where it makes sense, e.g.isFinal
.isAbstract()
- This is still available in subtypes, e.g.isAbstract
.isStrictfp()
- UsehasModifiers
instead, e.g.hasModifiers(STRICTFP)
.isSynchronized()
- UsehasModifiers
instead, e.g.hasModifiers(SYNCHRONIZED)
.isNative()
- UsehasModifiers
instead, e.g.hasModifiers(NATIVE)
.isStatic()
- This is still available in subtypes, e.g.isStatic
.isVolatile()
- UsehasModifiers
instead, e.g.hasModifiers(VOLATILE)
.isTransient()
- UsehasModifiers
instead, e.g.hasModifiers(TRANSIENT)
.isPrivate()
- UsegetVisibility
instead, e.g.getVisibility() == Visibility.V_PRIVATE
.isPublic()
- UsegetVisibility
instead, e.g.getVisibility() == Visibility.V_PUBLIC
.isProtected()
- UsegetVisibility
instead, e.g.getVisibility() == Visibility.V_PROTECTED
.isPackagePrivate()
- UsegetVisibility
instead, e.g.getVisibility() == Visibility.V_PACKAGE
.isSyntacticallyAbstract()
- UsehasExplicitModifiers
instead, e.g.hasExplicitModifiers(ABSTRACT)
.isSyntacticallyPublic()
- UsehasExplicitModifiers
instead, e.g.hasExplicitModifiers(PUBLIC)
.isSyntacticallyStatic()
- UsehasExplicitModifiers
instead, e.g.hasExplicitModifiers(STATIC)
.isSyntacticallyFinal()
- UsehasExplicitModifiers
instead, e.g.hasExplicitModifiers(FINAL)
.
TypeNode
- methodgetType()
has been removed. UsegetTypeMirror
instead.
- pmd-javascript
AbstractEcmascriptNode
- methodgetNode()
has been removed. AST nodes still have access to the underlying Rhino node via the protected propertynode
.ASTFunctionNode
- methodgetBody(int)
removed. UsegetBody
instead.ASTTryStatement
- method
isCatch()
has been removed. UsehasCatch
instead. - method
isFinally()
has been removed. UsehasFinally
instead.
- method
EcmascriptNode
- method
jjtAccept()
has been removed. UseacceptVisitor
instead. - method
getNode()
has been removed. The underlying node is only available in AST nodes, but not in rule implementations.
- method
net.sourceforge.pmd.lang.ecmascript.ast.EcmascriptParserVisitor
UseEcmascriptVisitor
orEcmascriptVisitorBase
instead.net.sourceforge.pmd.lang.ecmascript.ast.EcmascriptParserVisitorAdapter
- pmd-jsp
net.sourceforge.pmd.lang.jsp.ast.JspParserVisitor
UseJspVisitor
orJspVisitorBase
instead.net.sourceforge.pmd.lang.jsp.ast.JspParserVisitorAdapter
JspNode
- methodjjtAccept()
has been removed. UseacceptVisitor
instead.
- pmd-modelica
net.sourceforge.pmd.lang.modelica.ast.ModelicaParserVisitor
UseModelicaVisitor
orModelicaVisitorBase
instead.net.sourceforge.pmd.lang.modelica.ast.ModelicaParserVisitorAdapter
ModelicaNode
- methodjjtAccept()
has been removed. UseacceptVisitor
instead.net.sourceforge.pmd.lang.modelica.rule.AmbiguousResolutionRule
UseAmbiguousResolutionRule
instead.net.sourceforge.pmd.lang.modelica.rule.ConnectUsingNonConnector
UseConnectUsingNonConnectorRule
- pmd-plsql
net.sourceforge.pmd.lang.plsql.ast.PLSQLParserVisitor
UsePlsqlVisitor
orPlsqlVisitorBase
instead.net.sourceforge.pmd.lang.plsql.ast.PLSQLParserVisitorAdapter
PLSQLNode
- methodjjtAccept()
has been removed. UseacceptVisitor
instead.
- pmd-scala
- The maven module
pmd-scala
has been removed. Usepmd-scala_2.13
orpmd-scala_2.12
instead. ScalaNode
- Method
accept()
has been removed. UseacceptVisitor
instead. - Method
getNode()
has been removed. The underlying node is only available in AST nodes, but not in rule implementations.
- Method
AbstractScalaNode
- methodgetNode()
has been removed. AST nodes still have access to the underlying Scala node via the protected propertynode
.
- The maven module
- pmd-visualforce
VfNode
- methodjjtAccept()
has been removed. UseacceptVisitor
instead.net.sourceforge.pmd.lang.vf.ast.VfParserVisitor
UseVfVisitor
orVfVisitorBase
instead.net.sourceforge.pmd.lang.vf.ast.VfParserVisitorAdapter
DataType
- methodfromBasicType(BasicType)
has been removed. UsefromTypeName
instead.
- pmd-velocity (previously pmd-vm)
VtlNode
- methodjjtAccept()
has been removed. UseacceptVisitor
instead.net.sourceforge.pmd.lang.vm.ast.VmParserVisitor
UseVtlVisitor
orVtlVisitorBase
instead.net.sourceforge.pmd.lang.vm.ast.VmParserVisitorAdapter
Removed classes, interfaces and methods (not previously deprecated)
- pmd-apex
- The method
isSynthetic()
inASTMethod
has been removed. With the switch from Jorje to Summit AST as underlying parser, no synthetic methods are generated by the parser anymore. This also means, that there is no XPath attribute@Synthetic
anymore. - The constant
STATIC_INITIALIZER_METHOD_NAME
inFieldDeclarationsShouldBeAtStartRule
has been removed. It was used to filter out synthetic methods, but these are not generated anymore with the new parser. - The method
getContext()
inASTReferenceExpression
has been removed. It was not used and always returnednull
. - The method
getNamespace()
in all AST nodes (defined inApexNode
) has been removed, as it was never fully implemented. It always returned an empty string. - The method
getNameSpace()
inApexQualifiedName
has been removed. - The class
net.sourceforge.pmd.lang.apex.ast.ASTBridgeMethodCreator
has been removed. This was a node that has been generated by the old Jorje parser only.
- The method
- pmd-apex-jorje
- With the switch from Jorje to Summit AST, this maven module is no longer needed and has been removed.
- pmd-core
net.sourceforge.pmd.util.Predicate
has been removed. It was marked as Experimental before. Usejava.util.function.Predicate
instead.
- pmd-java
- The interface
FinalizableNode
(introduced in 7.0.0-rc1) has been removed. Its methodisFinal()
has been moved down to the nodes where needed, e.g.ASTLocalVariableDeclaration#isFinal
. - The method
isPackagePrivate()
inASTClassDeclaration
(formerly ASTClassOrInterfaceDeclaration) has been removed. UsehasVisibility
instead, which can correctly differentiate between local and package private classes.
- The interface
Renamed classes, interfaces, methods
- pmd-core
MessageReporter
has been renamed toPmdReporter
TokenMgrError
has been renamed toLexException
Tokenizer
has been renamed toCpdLexer
. Along with this rename, all the implementations have been renamed as well (Tokenizer
->CpdLexer
), e.g. “CppCpdLexer”, “JavaCpdLexer”. This affects all language modules.AnyTokenizer
has been renamed toAnyCpdLexer
.
- pmd-java
- The interface
AccessNode
has been renamed toModifierOwner
. This is only relevant for Java rules, which use that type directly e.g. through downcasting. Or when using the XPath functionpmd-java:nodeIs()
. - The node
ASTClassOrInterfaceType
has been renamed toASTClassType
. XPath rules need to be adjusted. - The node
ASTClassOrInterfaceDeclaration
has been renamed toASTClassDeclaration
. XPath rules need to be adjusted. - The interface
ASTAnyTypeDeclaration
has been renamed toASTTypeDeclaration
. This is only relevant for Java rules, which use that type directly, e.g. through downcasting. Or when using the XPath functionpmd-java:nodeIs()
. - The interface
ASTMethodOrConstructorDeclaration
has been renamed toASTExecutableDeclaration
. This is only relevant for Java rules, which use that type directly, e.g. through downcasting. Or when using the XPath functionpmd-java:nodeIs()
. - The node
ASTVariableDeclaratorId
has been renamed toASTVariableId
. XPath rules need to be adjusted. - The node
ASTClassOrInterfaceBody
has been renamed toASTClassBody
. XPath rules need to be adjusted.
- The interface
- pmd-scala
- The interface
ScalaParserVisitor
has been renamed toScalaVisitor
in order to align the naming scheme for the different language modules. - The class
ScalaParserVisitorAdapter
has been renamed toScalaVisitorBase
in order to align the naming scheme for the different language modules.
- The interface
New API
These were annotated with @Experimental
, but can now be considered stable.
- pmd-apex
- pmd-core
CPDReport#filterMatches
AntlrToken#getKind
AbstractJjtreeNode
TokenDocument
AstInfo#getSuppressionComments
AstInfo#withSuppressMap
GenericToken#getKind
FileCollector#addZipFileWithContent
net.sourceforge.pmd.lang.document
LanguageVersionHandler#getLanguageMetricsProvider
LanguageVersionHandler#getDesignerBindings
PlainTextLanguage
PropertyConstraint#getXmlConstraint
PropertyConstraint#toOptionalConstraint
PropertyConstraint#fromPredicate
PropertyConstraint#fromPredicate
AbstractRenderer#setReportFile
Renderer#setReportFile
DesignerBindings
DesignerBindings.TreeIconId
RelatedNodesSelector
Report#filterViolations
Report#union
- pmd-groovy
- pmd-html
- pmd-java
- pmd-kotlin
- pmd-test-schema
Removed functionality
- The CLI parameter
--no-ruleset-compatibility
has been removed. It was only used to allow loading some rulesets originally written for PMD 5 also in PMD 6 without fixing the rulesets. - The class
RuleSetFactoryCompatibility
has been removed without replacement. The different ways to enable/disable this filter inPMDConfiguration
(Property “RuleSetFactoryCompatibilityEnabled”) andPMDTask
(Property “noRuleSetCompatibility”) have been removed as well. textcolor
renderer (TextColorRenderer
) now renders always in color. The propertycolor
has been removed. The possibility to override this with the system propertypmd.color
has been removed as well. If you don’t want colors, usetext
renderer (TextRenderer
).
7.0.0-rc4
pmd-java
- Support for Java 19 preview language features have been removed. The version “19-preview” is no longer available.
Rule properties
- The old deprecated classes like
IntProperty
andStringProperty
have been removed. Please usePropertyFactory
to create properties. - All properties which accept multiple values now use a comma (
,
) as a delimiter. The previous default was a pipe character (|
). The delimiter is not configurable anymore. If needed, the comma can be escaped with a backslash. - The
min
andmax
attributes in property definitions in the XML are now optional and can appear separately or be omitted.
New Programmatic API for CPD
See Detailed Release Notes for PMD 7 and PR #4397 for details.
Removed classes and methods
The following previously deprecated classes have been removed:
- pmd-core
net.sourceforge.pmd.cpd.AbstractTokenizer
➡️ useAnyCpdLexer
instead (previously known as AnyTokenizer)net.sourceforge.pmd.cpd.CPD
➡️ usePmdCli
frompmd-cli
module for CLI support or useCpdAnalysis
for programmatic APInet.sourceforge.pmd.cpd.GridBagHelper
(now package private)net.sourceforge.pmd.cpd.TokenEntry.State
net.sourceforge.pmd.lang.document.CpdCompat
net.sourceforge.pmd.properties.BooleanMultiProperty
net.sourceforge.pmd.properties.BooleanProperty
net.sourceforge.pmd.properties.CharacterMultiProperty
net.sourceforge.pmd.properties.CharacterProperty
net.sourceforge.pmd.properties.DoubleMultiProperty
net.sourceforge.pmd.properties.DoubleProperty
net.sourceforge.pmd.properties.EnumeratedMultiProperty
net.sourceforge.pmd.properties.EnumeratedProperty
net.sourceforge.pmd.properties.EnumeratedPropertyDescriptor
net.sourceforge.pmd.properties.FileProperty
(note: without replacement)net.sourceforge.pmd.properties.FloatMultiProperty
net.sourceforge.pmd.properties.FloatProperty
net.sourceforge.pmd.properties.IntegerMultiProperty
net.sourceforge.pmd.properties.IntegerProperty
net.sourceforge.pmd.properties.LongMultiProperty
net.sourceforge.pmd.properties.LongProperty
net.sourceforge.pmd.properties.MultiValuePropertyDescriptor
net.sourceforge.pmd.properties.NumericPropertyDescriptor
net.sourceforge.pmd.properties.PropertyDescriptorField
net.sourceforge.pmd.properties.RegexProperty
net.sourceforge.pmd.properties.SingleValuePropertyDescriptor
net.sourceforge.pmd.properties.StringMultiProperty
net.sourceforge.pmd.properties.StringProperty
net.sourceforge.pmd.properties.ValueParser
net.sourceforge.pmd.properties.ValueParserConstants
net.sourceforge.pmd.properties.builders.MultiNumericPropertyBuilder
net.sourceforge.pmd.properties.builders.MultiPackagedPropertyBuilder
net.sourceforge.pmd.properties.builders.MultiValuePropertyBuilder
net.sourceforge.pmd.properties.builders.PropertyDescriptorBuilder
net.sourceforge.pmd.properties.builders.PropertyDescriptorBuilderConversionWrapper
net.sourceforge.pmd.properties.builders.PropertyDescriptorExternalBuilder
net.sourceforge.pmd.properties.builders.SingleNumericPropertyBuilder
net.sourceforge.pmd.properties.builders.SinglePackagedPropertyBuilder
net.sourceforge.pmd.properties.builders.SingleValuePropertyBuilder
net.sourceforge.pmd.properties.modules.EnumeratedPropertyModule
net.sourceforge.pmd.properties.modules.NumericPropertyModule
The following previously deprecated methods have been removed:
- pmd-core
net.sourceforge.pmd.properties.PropertyBuilder.GenericCollectionPropertyBuilder#delim(char)
net.sourceforge.pmd.properties.PropertySource#setProperty(...)
net.sourceforge.pmd.properties.internal.PropertyTypeId#factoryFor(...)
net.sourceforge.pmd.properties.internal.PropertyTypeId#typeIdFor(...)
net.sourceforge.pmd.properties.PropertyDescriptor
: removed methods errorFor, type, isMultiValue, uiOrder, compareTo, isDefinedExternally, valueFrom, asDelimitedString
The following methods have been removed:
- pmd-core
CPDConfiguration
#sourceCodeFor(File)
,#postConstruct()
,#tokenizer()
,#filenameFilter()
removed
Mark
#getSourceSlice()
,#setLineCount(int)
,#getLineCount()
,#setSourceCode(SourceCode)
removed#getBeginColumn()
,#getBeginLine()
,#getEndLine()
,#getEndColumn()
removed ➡️ usegetLocation
instead
Match
#LABEL_COMPARATOR
removed#setMarkSet(...)
,#setLabel(...)
,#getLabel()
,#addTokenEntry(...)
removed#getSourceCodeSlice()
removed ➡️ useCPDReport#getSourceCodeSlice
instead
TokenEntry
#getEOF()
,#clearImages()
,#getIdentifier()
,#getIndex()
,#setHashCode(int)
removed#EOF
removed ➡️ useisEof
instead
Parser.ParserTask
#getFileDisplayName()
removed ➡️ usegetFileId
instead (getFileId().getAbsolutePath()
)
The following classes have been removed:
- pmd-core
net.sourceforge.pmd.cpd.AbstractLanguage
net.sourceforge.pmd.cpd.AnyLanguage
net.sourceforge.pmd.cpd.Language
net.sourceforge.pmd.cpd.LanguageFactory
net.sourceforge.pmd.cpd.MatchAlgorithm
(now package private)net.sourceforge.pmd.cpd.MatchCollector
(now package private)net.sourceforge.pmd.cpd.SourceCode
(and all inner classes likeFileCodeLoader
, …)net.sourceforge.pmd.cpd.token.TokenFilter
Moved packages
- pmd-core
NumericConstraints
(old package:net.sourceforge.pmd.properties.constraints.NumericConstraints
)PropertyConstraint
(old package:net.sourceforge.pmd.properties.constraints.PropertyConstraint
)- not experimental anymore
ReportException
(old package:net.sourceforge.pmd.cpd
, moved to modulepmd-ant
)- it is now a RuntimeException
CPDReportRenderer
(old package:net.sourceforge.pmd.cpd.renderer
)AntlrTokenFilter
(old package:net.sourceforge.pmd.cpd.token
)BaseTokenFilter
(old package:net.sourceforge.pmd.cpd.token.internal
)JavaCCTokenFilter
(old package:net.sourceforge.pmd.cpd.token
)
Changed types and other changes
- pmd-core
PropertyDescriptor
is now a class (was an interface) and it is not comparable anymore.AbstractConfiguration#setSourceEncoding
- previously this method took a simple String for the encoding.
PMDConfiguration
andCPDConfiguration
- many getters and setters have been moved to the parent class
AbstractConfiguration
- many getters and setters have been moved to the parent class
CPDListener#addedFile
- no
File
parameter anymore
- no
CPDReport#getNumberOfTokensPerFile
returns aMap
ofFileId,Integer
instead ofString
CPDReport#filterMatches
now takes ajava.util.function.Predicate
as parameterCpdLexer
- Note: CpdLexer was previously named Tokenizer.
- constants are now
PropertyDescriptor
instead ofString
, to be used as language properties tokenize
changed parameters. Now takes aTextDocument
and aTokenFactory
(instead ofSourceCode
andTokens
).
Language
- method
#createProcessor(LanguagePropertyBundle)
moved toPmdCapableLanguage
- method
StringUtil#linesWithTrimIndent
now takes aChars
instead of aString
.
- All language modules (like pmd-apex, pmd-cpp, …)
- consistent package naming:
net.sourceforge.pmd.lang.<langId>.cpd
- adapted to use
CpdCapableLanguage
- consistent static method
#getInstance()
- removed constants like
ID
,TERSE_NAME
orNAME
. UsegetInstance().getName()
etc. instead
- consistent package naming:
Internal APIs
net.sourceforge.pmd.properties.internal.PropertyTypeId
Deprecated API
-
Language#getTerseName
➡️ usegetId
instead -
The method
ASTPattern#getParenthesisDepth
has been deprecated and will be removed. It was introduced for supporting parenthesized patterns, but that was removed with Java 21. It is only used when parsing code as java-19-preview.
Experimental APIs
- To support the Java preview language features “String Templates” and “Unnamed Patterns and Variables”, the following AST nodes have been introduced as experimental:
- The AST nodes for supporting “Record Patterns” and “Pattern Matching for switch” are not experimental anymore:
ASTRecordPattern
ASTPatternList
(Note: it was renamed fromASTComponentPatternList
)ASTGuard
(Note: it was renamed fromASTSwitchGuard
)
7.0.0-rc3
PMD Distribution
-
The asset filenames of PMD on GitHub Releases are now
pmd-dist-<version>-bin.zip
,pmd-dist-<version>-src.zip
andpmd-dist-<version>-doc.zip
. Keep that in mind, if you have an automated download script.The structure inside the ZIP files stay the same, e.g. we still provide inside the binary distribution ZIP file the base directory
pmd-bin-<version>
.
CLI
- The CLI option
--stress
(or-stress
) has been removed without replacement. - The CLI option
--minimum-priority
was changed with 7.0.0-rc1 to only take the following values: High, Medium High, Medium, Medium Low, Low. With 7.0.0-rc2 compatibility has been restored, so that the equivalent integer values (1 to 5) are supported as well.
pmd-core
-
Replaced
RuleViolation::getFilename
with newRuleViolation#getFileId
, that returns aFileId
. This is an identifier for aTextFile
and could represent a path name. This allows to have a separate display name, e.g. renderers useFileNameRenderer
to either display the full path name or a relative path name (seeRenderer#setFileNameRenderer
andConfigurableFileNameRenderer
). Many places where we used a simple String for a path-like name before have been adapted to use the newFileId
.See PR #4425 for details.
7.0.0-rc2
Removed classes and methods
The following previously deprecated classes have been removed:
- pmd-core
net.sourceforge.pmd.PMD
net.sourceforge.pmd.cli.PMDCommandLineInterface
net.sourceforge.pmd.cli.PMDParameters
net.sourceforge.pmd.cli.PmdParametersParseResult
CLI
- The CLI option
--minimum-priority
was changed with 7.0.0-rc1 to only take the following values: High, Medium High, Medium, Medium Low, Low. With 7.0.0-rc2 compatibility has been restored, so that the equivalent integer values (1 to 5) are supported as well.
7.0.0-rc1
CLI
- The CLI option
--stress
(or-stress
) has been removed without replacement. - The CLI option
--minimum-priority
now takes one of the following values instead of an integer: High, Medium High, Medium, Medium Low, Low.
6.55.0
Go
- The LanguageModule of Go, that only supports CPD execution, has been deprecated. This language is not fully supported by PMD, so having a language module does not make sense. The functionality of CPD is not affected by this change. The following class has been deprecated and will be removed with PMD 7.0.0:
Java
- Support for Java 18 preview language features have been removed. The version “18-preview” is no longer available.
- The experimental class
net.sourceforge.pmd.lang.java.ast.ASTGuardedPattern
has been removed.
6.54.0
PMD CLI
- PMD now supports a new
--relativize-paths-with
flag (or short-z
), which replaces--short-names
. It serves the same purpose: Shortening the pathnames in the reports. However, with the new flag it’s possible to explicitly define one or more pathnames that should be used as the base when creating relative paths. The old flag--short-names
is deprecated.
Deprecated APIs
For removal
ApexRootNode#getApexVersion()
has been deprecated for removal. The version returned is alwaysVersion.CURRENT
, as the apex compiler integration doesn’t use additional information which Apex version actually is used. Therefore, this method can’t be used to determine the Apex version of the project that is being analyzed.CPDConfiguration#setEncoding
andCPDConfiguration#getEncoding
. Use the methodsgetSourceEncoding
andsetSourceEncoding
instead. Both are available forCPDConfiguration
which extendsAbstractConfiguration
.BaseCLITest
andBaseCPDCLITest
have been deprecated for removal without replacement. CLI tests should be done in pmd-core only (and in PMD7 in pmd-cli). Individual language modules shouldn’t need to test the CLI integration logic again. Instead, the individual language modules should test their functionality as unit tests.-
FileCollector#addZipFile
has been deprecated. It is replaced byFileCollector#addZipFileWithContent
which directly adds the content of the zip file for analysis. PMDConfiguration#setReportShortNames
andPMDConfiguration#isReportShortNames
have been deprecated for removal. UseAbstractConfiguration#addRelativizeRoot
instead.
Internal APIs
CSVWriter
- Some fields in
AbstractAntTestHelper
Experimental APIs
- CPDReport has a new method which limited mutation of a given report:
filterMatches
creates a new CPD report with some matches removed with a given predicate based filter.
6.53.0
Deprecated APIs
For removal
These classes / APIs have been deprecated and will be removed with PMD 7.0.0.
ExcessiveLengthRule
(Java)
6.52.0
PMD CLI
-
PMD now supports a new
--use-version
flag, which receives a language-version pair (such asjava-8
orapex-54
). This supersedes the usage of-language
/-l
and-version
/-v
, allowing for multiple versions to be set in a single run. PMD 7 will completely remove support for-language
and-version
in favor of this new flag. -
Support for
-V
is being deprecated in favor of--verbose
in preparation for PMD 7. In PMD 7,-v
will enable verbose mode and-V
will show the PMD version for consistency with most Unix/Linux tools. -
Support for
-min
is being deprecated in favor of--minimum-priority
for consistency with most Unix/Linux tools, where-min
would be equivalent to-m -i -n
.
CPD CLI
- CPD now supports using
-d
or--dir
as an alias to--files
, in favor of consistency with PMD. PMD 7 will remove support for--files
in favor of these new flags.
Linux run.sh parameters
-
Using
run.sh cpdgui
will now warn about it being deprecated. Userun.sh cpd-gui
instead. -
The old designer (
run.sh designerold
) is completely deprecated and will be removed in PMD 7. Switch to the new JavaFX designer:run.sh designer
. -
The old visual AST viewer (
run.sh bgastviewer
) is completely deprecated and will be removed in PMD 7. Switch to the new JavaFX designer:run.sh designer
for a visual tool, or userun.sh ast-dump
for a text-based alternative.
Deprecated API
- The following core APIs have been marked as deprecated for removal in PMD 7:
PMD
andPMD.StatusCode
- PMD 7 will ship with a revamped CLI split from pmd-core. To programmatically launch analysis you can usePmdAnalysis
.PMDConfiguration#getAllInputPaths
- It is now superseded byPMDConfiguration#getInputPathList
PMDConfiguration#setInputPaths
- It is now superseded byPMDConfiguration#setInputPathList
PMDConfiguration#addInputPath
- It is now superseded byPMDConfiguration#addInputPath
PMDConfiguration#getInputFilePath
- It is now superseded byPMDConfiguration#getInputFile
PMDConfiguration#getIgnoreFilePath
- It is now superseded byPMDConfiguration#getIgnoreFile
PMDConfiguration#setInputFilePath
- It is now superseded byPMDConfiguration#setInputFilePath
PMDConfiguration#setIgnoreFilePath
- It is now superseded byPMDConfiguration#setIgnoreFilePath
PMDConfiguration#getInputUri
- It is now superseded byPMDConfiguration#getUri
PMDConfiguration#setInputUri
- It is now superseded byPMDConfiguration#setInputUri
PMDConfiguration#getReportFile
- It is now superseded byPMDConfiguration#getReportFilePath
PMDConfiguration#setReportFile
- It is now superseded byPMDConfiguration#setReportFile
PMDConfiguration#isStressTest
andPMDConfiguration#setStressTest
- Will be removed with no replacement.PMDConfiguration#isBenchmark
andPMDConfiguration#setBenchmark
- Will be removed with no replacement, the CLI will still support it.CPD
andCPD.StatusCode
- PMD 7 will ship with a revamped CLI split from pmd-core. An alternative to programmatically launch CPD analysis will be added in due time.
- In order to reduce the dependency on Apex Jorje classes, the method
DataType#fromBasicType
has been deprecated. The equivalent methodfromTypeName
should be used instead.
6.51.0
No changes.
6.50.0
CPD CLI
- CPD now supports the
--ignore-literal-sequences
argument when analyzing Lua code.
6.49.0
Deprecated API
- In order to reduce the dependency on Apex Jorje classes, the following methods have been deprecated.
These methods all leaked internal Jorje enums. These enums have been replaced now by enums the
PMD’s AST package.
ASTAssignmentExpression#getOperator
ASTBinaryExpression#getOperator
ASTBooleanExpression#getOperator
ASTPostfixExpression#getOperator
ASTPrefixExpression#getOperator
All these classes have now a new
getOp()
method. Existing code should be refactored to use this method instead. It returns the new enums, likeAssignmentOperator
, and avoids the dependency to Jorje.
6.48.0
CPD CLI
- CPD has a new CLI option
--debug
. This option has the same behavior as in PMD. It enables more verbose logging output.
Rule Test Framework
- The module “pmd-test”, which contains support classes to write rule tests, now requires Java 8. If you depend on this module for testing your own custom rules, you’ll need to make sure to use at least Java 8.
- The new module “pmd-test-schema” contains now the XSD schema and the code to parse the rule test XML files. The schema has been extracted in order to easily share it with other tools like the Rule Designer or IDE plugins.
- Test schema changes:
- The attribute
isRegressionTest
oftest-code
is deprecated. The new attributedisabled
should be used instead for defining whether a rule test should be skipped or not. - The attributes
reinitializeRule
anduseAuxClasspath
oftest-code
are deprecated and assumed true. They will not be replaced. - The new attribute
focused
oftest-code
allows disabling all tests except the focused one temporarily.
- The attribute
- More information about the rule test framework can be found in the documentation: Testing your rules
Deprecated API
- The experimental Java AST class
net.sourceforge.pmd.lang.java.ast.ASTGuardedPattern
has been deprecated and will be removed. It was introduced for Java 17 and Java 18 Preview as part of pattern matching for switch, but it is no longer supported with Java 19 Preview. - The interface
CPDRenderer
is deprecated. For custom CPD renderers the new interfaceCPDReportRenderer
should be used. - The class
TestDescriptor
is deprecated, replaced withRuleTestDescriptor
. - Many methods of
RuleTst
have been deprecated as internal API.
Experimental APIs
- To support the Java preview language features “Pattern Matching for Switch” and “Record Patterns”, the following AST nodes have been introduced as experimental:
Internal API
Those APIs are not intended to be used by clients, and will be hidden or removed with PMD 7.0.0.
You can identify them with the @InternalApi
annotation. You’ll also get a deprecation warning.
CPDConfiguration#setRenderer
CPDConfiguration#setCPDRenderer
CPDConfiguration#getRenderer
CPDConfiguration#getCPDRenderer
CPDConfiguration#getRendererFromString
CPDConfiguration#getCPDRendererFromString
CPDRendererAdapter
6.47.0
No changes.
6.46.0
Deprecated ruleset references
Ruleset references with the following formats are now deprecated and will produce a warning when used on the CLI or in a ruleset XML file:
<lang-name>-<ruleset-name>
, egjava-basic
, which resolves torulesets/java/basic.xml
- the internal release number, eg
600
, which resolves torulesets/releases/600.xml
Use the explicit forms of these references to be compatible with PMD 7.
Deprecated API
toString
is now deprecated. The format of this method will remain the same until PMD 7. The deprecation is intended to steer users away from relying on this format, as it may be changed in PMD 7.getInputPaths
andsetInputPaths
are now deprecated. A new set of methods have been added, which use lists and do not rely on comma splitting.
Internal API
Those APIs are not intended to be used by clients, and will be hidden or removed with PMD 7.0.0.
You can identify them with the @InternalApi
annotation. You’ll also get a deprecation warning.
CPDCommandLineInterface
has been internalized. In order to execute CPD eitherCPD#runCpd
orCPD#main
should be used.- Several members of
BaseCPDCLITest
have been deprecated with replacements. - The methods
Formatter#start
,Formatter#end
,Formatter#getRenderer
, andFormatter#isNoOutputSupplied
have been internalized.
6.45.0
Experimental APIs
- Report has two new methods which allow limited mutations of a given report:
Report#filterViolations
creates a new report with some violations removed with a given predicate based filter.Report#union
can combine two reports into a single new Report.
net.sourceforge.pmd.util.Predicate
will be replaced in PMD7 with the standard Predicate interface from java8.- The module
pmd-html
is entirely experimental right now. Anything in the packagenet.sourceforge.pmd.lang.html
should be used cautiously.
6.44.0
Deprecated API
- Several members of
PMD
have been newly deprecated, including:PMD#EOL
: useSystem#lineSeparator()
PMD#SUPPRESS_MARKER
: useDEFAULT_SUPPRESS_MARKER
PMD#processFiles
: use the new programmatic APIPMD#getApplicableFiles
: is internal
PMDConfiguration#prependClasspath
is deprecated in favour ofprependAuxClasspath
.PMDConfiguration#setRuleSets
andgetRuleSets
are deprecated. Use insteadsetRuleSets
,addRuleSet
, andgetRuleSetPaths
.- Several members of
BaseCLITest
have been deprecated with replacements. -
Several members of
PMDCommandLineInterface
have been explicitly deprecated. The whole class however was deprecated long ago already with 6.30.0. It is internal API and should not be used. - In modelica, the rule classes
AmbiguousResolutionRule
andConnectUsingNonConnector
have been deprecated, since they didn’t comply to the usual rule class naming conventions yet. The replacements are in the subpackagebestpractices
.
Experimental APIs
-
Together with the new programmatic API the interface
TextFile
has been added as experimental. It intends to replaceDataSource
andSourceCode
in the long term.This interface will change in PMD 7 to support read/write operations and other things. You don’t need to use it in PMD 6, as
FileCollector
decouples you from this. A file collector is available throughPmdAnalysis#files
.
6.43.0
Deprecated API
Some API deprecations were performed in core PMD classes, to improve compatibility with PMD 7.
Report
: the constructor and other construction methods like addViolation or createReportRuleContext
: all constructors, getters and setters. A new set of stable methods, matching those in PMD 7, was added to replace theaddViolation
overloads ofAbstractRule
. In PMD 7,RuleContext
will be the API to report violations, and it can already be used as such in PMD 6.- The field
configuration
is unused and will be removed.
Internal API
Those APIs are not intended to be used by clients, and will be hidden or removed with PMD 7.0.0.
You can identify them with the @InternalApi
annotation. You’ll also get a deprecation warning.
RuleSet
: methods that serve to apply rules, includingapply
,start
,end
,removeDysfunctionalRules
AbstractAccumulatingRenderer#renderFileReport
is internal API and should not be overridden in own renderers.
Changed API
It is now forbidden to report a violation:
- With a
null
node - With a
null
message - With a
null
set of format arguments (prefer a zero-length array)
Note that the message is set from the XML rule declaration, so this is only relevant if you instantiate rules manually.
RuleContext
now requires setting the current rule before calling
apply
. This is
done automatically by RuleSet#apply
and such. Creating and configuring a
RuleContext
manually is strongly advised against, as the lifecycle of RuleContext
will change drastically in PMD 7.
6.42.0
No changes.
6.41.0
Command Line Interface
The command line options for PMD and CPD now use GNU-syle long options format. E.g. instead of -rulesets
the
preferred usage is now --rulesets
. Alternatively one can still use the short option -R
.
Some options also have been renamed to a more consistent casing pattern at the same time
(--fail-on-violation
instead of -failOnViolation
).
The old single-dash options are still supported but are deprecated and will be removed with PMD 7.
This change makes the command line interface more consistent within PMD and also less surprising
compared to other cli tools.
The changes in detail for PMD:
old option | new option |
---|---|
-rulesets |
--rulesets (or -R ) |
-uri |
--uri |
-dir |
--dir (or -d ) |
-filelist |
--file-list |
-ignorelist |
--ignore-list |
-format |
--format (or -f ) |
-debug |
--debug |
-verbose |
--verbose |
-help |
--help |
-encoding |
--encoding |
-threads |
--threads |
-benchmark |
--benchmark |
-stress |
--stress |
-shortnames |
--short-names |
-showsuppressed |
--show-suppressed |
-suppressmarker |
--suppress-marker |
-minimumpriority |
--minimum-priority |
-property |
--property |
-reportfile |
--report-file |
-force-language |
--force-language |
-auxclasspath |
--aux-classpath |
-failOnViolation |
--fail-on-violation |
--failOnViolation |
--fail-on-violation |
-norulesetcompatibility |
--no-ruleset-compatibility |
-cache |
--cache |
-no-cache |
--no-cache |
The changes in detail for CPD:
old option | new option |
---|---|
--failOnViolation |
--fail-on-violation |
-failOnViolation |
--fail-on-violation |
--filelist |
--file-list |
6.40.0
Experimental APIs
- The interface
ASTCommentContainer
has been added to the Apex AST. It provides a way to check whether a node contains at least one comment. Currently, this is only implemented forASTCatchBlockStatement
and used by the ruleEmptyCatchBlock
. This information is also available via XPath attribute@ContainsComment
.
6.39.0
No changes.
6.38.0
No changes.
6.37.0
PMD CLI
-
PMD has a new CLI option
-force-language
. With that a language can be forced to be used for all input files, irrespective of filenames. When using this option, the automatic language selection by extension is disabled and all files are tried to be parsed with the given language. Parsing errors are ignored and unparsable files are skipped.This option allows to use the xml language for files, that don’t use xml as extension. See also the examples on PMD CLI reference.
Experimental APIs
- The AST types and APIs around Sealed Classes are not experimental anymore:
ASTClassOrInterfaceDeclaration#isSealed
,ASTClassOrInterfaceDeclaration#isNonSealed
,ASTClassOrInterfaceDeclaration#getPermittedSubclasses
ASTPermitsList
Internal API
Those APIs are not intended to be used by clients, and will be hidden or removed with PMD 7.0.0.
You can identify them with the @InternalApi
annotation. You’ll also get a deprecation warning.
- The inner class
net.sourceforge.pmd.cpd.TokenEntry.State
is considered to be internal API. It will probably be moved away with PMD 7.
6.36.0
No changes.
6.35.0
Deprecated API
PMD#doPMD
is deprecated. UsePMD#runPmd
instead.PMD#run
is deprecated. UsePMD#runPmd
instead.ThreadSafeReportListener
and the methods to use them inReport
(addListener
,getListeners
,addListeners
) are deprecated. This functionality will be replaced by another TBD mechanism in PMD 7.
6.34.0
No changes.
6.33.0
No changes.
6.32.0
Experimental APIs
- The experimental class
ASTTypeTestPattern
has been renamed toASTTypePattern
in order to align the naming to the JLS. - The experimental class
ASTRecordConstructorDeclaration
has been renamed toASTCompactConstructorDeclaration
in order to align the naming to the JLS. - The AST types and APIs around Pattern Matching and Records are not experimental anymore:
ASTVariableId#isPatternBinding
ASTPattern
ASTTypePattern
ASTRecordDeclaration
ASTRecordComponentList
ASTRecordComponent
ASTRecordBody
ASTCompactConstructorDeclaration
Internal API
Those APIs are not intended to be used by clients, and will be hidden or removed with PMD 7.0.0.
You can identify them with the @InternalApi
annotation. You’ll also get a deprecation warning.
- The protected or public member of the Java rule
AvoidUsingHardCodedIPRule
are deprecated and considered to be internal API. They will be removed with PMD 7.
6.31.0
Deprecated API
AbstractDomXmlRule
AbstractWsdlRule
- A few methods of
AbstractXmlRule
Experimental APIs
- The method
GenericToken#getKind
has been added as experimental. This unifies the token interface for both JavaCC and Antlr. The already existing methodAntlrToken#getKind
is therefore experimental as well. The returned constant depends on the actual language and might change whenever the grammar of the language is changed.
6.30.0
Deprecated API
Around RuleSet parsing
RuleSetFactory
andRulesetsFactoryUtils
have been deprecated in favor ofRuleSetLoader
. This is easier to configure, and more maintainable than the multiple overloads ofRulesetsFactoryUtils
.- Some static creation methods have been added to
RuleSet
for simple cases, egforSingleRule
. These replace some counterparts inRuleSetFactory
- Since
RuleSets
is also deprecated, many APIs that require a RuleSets instance now are deprecated, and have a counterpart that expects aList<RuleSet>
. RuleSetReferenceId
,RuleSetReference
,RuleSetFactoryCompatibility
are deprecated. They are most likely not relevant outside of the implementation of pmd-core.
Around the PMD
class
Many classes around PMD’s entry point (PMD
) have been deprecated as internal, including:
- The contents of the packages
net.sourceforge.pmd.cli
in pmd-core,net.sourceforge.pmd.processor
SourceCodeProcessor
- The constructors of
PMD
(the class will be made a utility class)
Miscellaneous
ASTPackageDeclaration#getPackageNameImage
,ASTTypeParameter#getParameterName
and the corresponding XPath attributes. In both cases they’re replaced with a new methodgetName
, the attribute is@Name
.ASTClassOrInterfaceBody#isAnonymousInnerClass
, andASTClassOrInterfaceBody#isEnumChild
, refs #905
Internal API
Those APIs are not intended to be used by clients, and will be hidden or removed with PMD 7.0.0.
You can identify them with the @InternalApi
annotation. You’ll also get a deprecation warning.
net.sourceforge.pmd.lang.ecmascript.Ecmascript3Handler
net.sourceforge.pmd.lang.ecmascript.Ecmascript3Parser
EcmascriptParser#parserOptions
EcmascriptParser#getSuppressMap
net.sourceforge.pmd.lang.rule.ParametricRuleViolation
ParserOptions#suppressMarker
net.sourceforge.pmd.lang.modelica.rule.ModelicaRuleViolationFactory
6.29.0
No changes.
6.28.0
Deprecated API
For removal
net.sourceforge.pmd.RuleViolationComparator
. UseRuleViolation#DEFAULT_COMPARATOR
instead.net.sourceforge.pmd.cpd.AbstractTokenizer
. Usenet.sourceforge.pmd.cpd.AnyCpdLexer
instead (previously called AnyTokenizer).net.sourceforge.pmd.cpd.FortranTokenizer
. Was replaced by anAnyCpdLexer
. UseFortranLanguageModule#createCpdLexer
anyway.net.sourceforge.pmd.cpd.PerlTokenizer
. Was replaced by anAnyCpdLexer
. UsePerlLanguageModule#createCpdLexer
anyway.net.sourceforge.pmd.cpd.RubyTokenizer
. Was replaced by anAnyCpdLexer
. UseRubyLanguageModule#createCpdLexer
anyway.RuleReference#getOverriddenLanguage
andRuleReference#setLanguage
- Antlr4 generated lexers:
net.sourceforge.pmd.lang.cs.antlr4.CSharpLexer
will be moved to packagenet.sourceforge.pmd.lang.cs.ast
with PMD 7.net.sourceforge.pmd.lang.dart.antlr4.Dart2Lexer
will be renamed toDartLexer
and moved to packagenet.sourceforge.pmd.lang.dart.ast
with PMD 7. All other classes in the old package will be removed.net.sourceforge.pmd.lang.go.antlr4.GolangLexer
will be moved to packagenet.sourceforge.pmd.lang.go.ast
with PMD 7. All other classes in the old package will be removed.net.sourceforge.pmd.lang.kotlin.antlr4.Kotlin
will be renamed toKotlinLexer
and moved to packagenet.sourceforge.pmd.lang.kotlin.ast
with PMD 7.net.sourceforge.pmd.lang.lua.antlr4.LuaLexer
will be moved to packagenet.sourceforge.pmd.lang.lua.ast
with PMD 7. All other classes in the old package will be removed.
6.27.0
- XML rule definition in rulesets: In PMD 7, the
language
attribute will be required on allrule
elements that declare a new rule. Some base rule classes set the language implicitly in their constructor, and so this is not required in all cases for the rule to work. But this behavior will be discontinued in PMD 7, so missinglanguage
attributes are now reported as a forward compatibility warning.
Deprecated API
For removal
Rule#getParserOptions
Parser#getParserOptions
AbstractParser
RuleContext#removeAttribute
RuleContext#getAttribute
RuleContext#setAttribute
ApexParserOptions
ASTThrowStatement#getFirstClassOrInterfaceTypeImage
EcmascriptParserOptions
EcmascriptXPathRule
XmlParserOptions
XmlXPathRule
-
Properties of
AbstractXmlRule
net.sourceforge.pmd.Report.ReadableDuration
-
Many methods of
net.sourceforge.pmd.Report
. They are replaced by accessors that produce a List. For example,iterator()
(and implementing Iterable) andisEmpty()
are both replaced bygetViolations()
. - The dataflow codebase is deprecated for removal in PMD 7. This includes all code in the following packages, and their subpackages:
ASTJspDeclarations
ASTJspDocument
ScalaParserVisitorAdapter#zero
ScalaParserVisitorAdapter#combine
ApexParserVisitorReducedAdapter
TypeHelper
is deprecated in favor ofTypeTestUtil
, which has the same functionality, but a slightly changed API.- Many of the classes in
net.sourceforge.pmd.lang.java.symboltable
are deprecated as internal API.
6.26.0
Deprecated API
For removal
RuleChainVisitor
and all implementations in language modulesAbstractRuleChainVisitor
Language#getRuleChainVisitorClass
BaseLanguageModule#<init>
ImportWrapper
6.25.0
-
The maven module
net.sourceforge.pmd:pmd-scala
is deprecated. Usenet.sourceforge.pmd:pmd-scala_2.13
ornet.sourceforge.pmd:pmd-scala_2.12
instead. -
Rule implementation classes are internal API and should not be used by clients directly. The rules should only be referenced via their entry in the corresponding category ruleset (e.g.
<rule ref="category/java/bestpractices.xml/AbstractClassWithoutAbstractMethod" />
).While we definitely won’t move or rename the rule classes in PMD 6.x, we might consider changes in PMD 7.0.0 and onwards.
Deprecated APIs
Internal API
Those APIs are not intended to be used by clients, and will be hidden or removed with PMD 7.0.0.
You can identify them with the @InternalApi
annotation. You’ll also get a deprecation warning.
AbstractIgnoredAnnotationRule
(Java)AbstractInefficientZeroCheck
(Java)AbstractJUnitRule
(Java)AbstractJavaMetricsRule
(Java)AbstractLombokAwareRule
(Java)AbstractPoorMethodCall
(Java)AbstractSunSecureRule
(Java)AbstractNcssCountRule
(Java)AbstractCommentRule
(Java)AbstractOptimizationRule
(Java)RegexHelper
(Java)AbstractApexUnitTestRule
(Apex)AbstractNcssCountRule
(Apex)AbstractNcssCountRule
(PLSQL)ApexParser
ApexHandler
RuleChain
RuleSets
RulesetsFactoryUtils#getRuleSets
For removal
TokenEntry#TokenEntry
AbstractTokenizerTest
. Use CpdTextComparisonTest in module pmd-lang-test instead. For details see Testing your implementation in the developer documentation.ASTAnnotation#suppresses
(Apex)ApexXPathRule
(Apex)SymbolTableTestRule
(Java)InefficientStringBufferingRule#isInStringBufferOperation
6.24.0
Deprecated APIs
BaseLanguageModule#addVersion(String, LanguageVersionHandler, boolean)
- Some members of
TokenMgrError
, in particular, a new constructor is available that should be preferred to the old ones ANTLRSyntaxError
Experimental APIs
Note: Experimental APIs are identified with the annotation Experimental
,
see its javadoc for details
- The experimental methods in
BaseLanguageModule
have been replaced by a definitive API.
6.23.0
Deprecated APIs
Internal API
Those APIs are not intended to be used by clients, and will be hidden or removed with PMD 7.0.0.
You can identify them with the @InternalApi
annotation. You’ll also get a deprecation warning.
In ASTs
As part of the changes we’d like to do to AST classes for 7.0.0, we would like to hide some methods and constructors that rule writers should not have access to. The following usages are now deprecated in the Apex, Javascript, PL/SQL, Scala and Visualforce ASTs:
- Manual instantiation of nodes. Constructors of node classes are deprecated and
marked
InternalApi
. Nodes should only be obtained from the parser, which for rules, means that they never need to instantiate node themselves. Those constructors will be made package private with 7.0.0. - Subclassing of abstract node classes, or usage of their type. The base classes are internal API and will be hidden in version 7.0.0. You should not couple your code to them.
- In the meantime you should use interfaces like
VfNode
orNode
, or the other published interfaces in this package, to refer to nodes generically. - Concrete node classes will be made final with 7.0.0.
- Setters found in any node class or interface. Rules should consider the AST immutable. We will make those setters package private with 7.0.0.
- The implementation classes of
Parser
(egVfParser
) are deprecated and should not be used directly. UseLanguageVersionHandler#getParser
instead. - The implementation classes of
TokenManager
(egVfTokenManager
) are deprecated and should not be used outside of our implementation. This also affects CPD-only modules.
These deprecations are added to the following language modules in this release. Please look at the package documentation to find out the full list of deprecations.
- Apex:
net.sourceforge.pmd.lang.apex.ast
- Javascript:
net.sourceforge.pmd.lang.ecmascript.ast
- PL/SQL:
net.sourceforge.pmd.lang.plsql.ast
- Scala:
net.sourceforge.pmd.lang.scala.ast
- Visualforce:
net.sourceforge.pmd.lang.vf.ast
These deprecations have already been rolled out in a previous version for the following languages:
- Java:
net.sourceforge.pmd.lang.java.ast
- Java Server Pages:
net.sourceforge.pmd.lang.jsp.ast
- Velocity Template Language:
net.sourceforge.pmd.lang.vm.ast
Outside of these packages, these changes also concern the following TokenManager implementations, and their corresponding Parser if it exists (in the same package):
CppTokenManager
JavaTokenManager
Ecmascript5TokenManager
JspTokenManager
MatlabTokenManager
ModelicaTokenManager
ObjectiveCTokenManager
PLSQLTokenManager
PythonTokenManager
VfTokenManager
VmTokenManager
In the Java AST the following attributes are deprecated and will issue a warning when used in XPath rules:
ASTAdditiveExpression#getImage
- usegetOperator()
insteadASTVariableDeclaratorId#getImage
- usegetName()
insteadASTVariableDeclaratorId#getVariableName
- usegetName()
instead
For removal
Parser#getTokenManager
TokenManager#setFileName
AbstractTokenManager#setFileName
AbstractTokenManager#getFileName
AntlrToken#getType
- usegetKind()
instead.ImmutableLanguage
MockRule
Node#getFirstParentOfAnyType
Node#getAsDocument
AbstractNode#hasDescendantOfAnyType
ASTRecordDeclaration#getComponentList
- Multiple fields, constructors and methods in
XPathRule
. See javadoc for details.
6.22.0
Deprecated APIs
Internal API
Those APIs are not intended to be used by clients, and will be hidden or removed with PMD 7.0.0.
You can identify them with the @InternalApi
annotation. You’ll also get a deprecation warning.
JavaLanguageHandler
JavaLanguageParser
JavaDataFlowHandler
- Implementations of
RuleViolationFactory
in each language module, egJavaRuleViolationFactory
. See javadoc ofRuleViolationFactory
. -
Implementations of
RuleViolation
in each language module, egJavaRuleViolation
. See javadoc ofRuleViolation
. RuleFactory
RuleBuilder
- Constructors of
RuleSetFactory
, use factory methods fromRulesetsFactoryUtils
instead AbstractApexNode
AbstractApexNodeBase
, and the relatedvisit
methods onApexParserVisitor
and its implementations. UseApexNode
instead, now considers comments too.
For removal
- pmd-core
DFAGraphRule
and its implementationsDFAGraphMethod
- Many methods on the
Node
interface andAbstractNode
base class. See their javadoc for details. Node#isFindBoundary
is deprecated for XPath queries.- Many APIs of
net.sourceforge.pmd.lang.metrics
, though most of them were internal and probably not used directly outside of PMD. UseMetricsUtil
as a replacement for the language-specific façades too. QualifiableNode
,QualifiedName
- pmd-java
AbstractJavaParser
AbstractJavaHandler
ASTAnyTypeDeclaration.TypeKind
ASTAnyTypeDeclaration#getTypeKind
JavaQualifiedName
ASTCatchStatement#getBlock
ASTCompilationUnit#declarationsAreInDefaultPackage
JavaQualifiableNode
net.sourceforge.pmd.lang.java.qname
and its contentsMethodLikeNode
- Its methods will also be removed from its implementations,
ASTMethodOrConstructorDeclaration
,ASTLambdaExpression
.
- Its methods will also be removed from its implementations,
ASTAnyTypeDeclaration#getImage
will be removed. Please usegetSimpleName()
instead. This affectsASTAnnotationTypeDeclaration#getImage
,ASTClassOrInterfaceDeclaration#getImage
, andASTEnumDeclaration#getImage
.- Several methods of
ASTTryStatement
, replacements with other names have been added. This includes the XPath attribute@Finally
, replace it with a test forchild::FinallyStatement
. - Several methods named
getGuardExpressionNode
are replaced withgetCondition
. This affects the following nodes: WhileStatement, DoStatement, ForStatement, IfStatement, AssertStatement, ConditionalExpression. ASTYieldStatement
will not implementTypeNode
anymore come 7.0.0. Test the type of the expression nested within it.JavaMetrics
,JavaMetricsComputer
ASTArguments#getArgumentCount
. Usesize
instead.ASTFormalParameters#getParameterCount
. Usesize
instead.
- pmd-apex
In ASTs (JSP)
As part of the changes we’d like to do to AST classes for 7.0.0, we would like to hide some methods and constructors that rule writers should not have access to. The following usages are now deprecated in the JSP AST (with other languages to come):
- Manual instantiation of nodes. Constructors of node classes are deprecated and
marked
InternalApi
. Nodes should only be obtained from the parser, which for rules, means that they never need to instantiate node themselves. Those constructors will be made package private with 7.0.0. - Subclassing of abstract node classes, or usage of their type. The base classes are internal API and will be hidden in version 7.0.0. You should not couple your code to them.
- In the meantime you should use interfaces like
JspNode
orNode
, or the other published interfaces in this package, to refer to nodes generically. - Concrete node classes will be made final with 7.0.0.
- Setters found in any node class or interface. Rules should consider the AST immutable. We will make those setters package private with 7.0.0.
- The class
JspParser
is deprecated and should not be used directly. UseLanguageVersionHandler#getParser
instead.
Please look at net.sourceforge.pmd.lang.jsp.ast
to find out the full list of deprecations.
In ASTs (Velocity)
As part of the changes we’d like to do to AST classes for 7.0.0, we would like to hide some methods and constructors that rule writers should not have access to. The following usages are now deprecated in the VM AST (with other languages to come):
- Manual instantiation of nodes. Constructors of node classes are deprecated and
marked
InternalApi
. Nodes should only be obtained from the parser, which for rules, means that they never need to instantiate node themselves. Those constructors will be made package private with 7.0.0. - Subclassing of abstract node classes, or usage of their type. The base classes are internal API and will be hidden in version 7.0.0. You should not couple your code to them.
- In the meantime you should use interfaces like
VtlNode
orNode
, or the other published interfaces in this package, to refer to nodes generically. - Concrete node classes will be made final with 7.0.0.
- Setters found in any node class or interface. Rules should consider the AST immutable. We will make those setters package private with 7.0.0.
- The package
net.sourceforge.pmd.lang.vm.directive
as well as the classesDirectiveMapper
andLogUtil
are deprecated for removal. They were only used internally during parsing. - The class
VmParser
is deprecated and should not be used directly. UseLanguageVersionHandler#getParser
instead.
Please look at net.sourceforge.pmd.lang.vm.ast
to find out the full list of deprecations.
PLSQL AST
The production and node ASTCursorBody
was unnecessary, not used and has been removed. Cursors have been already
parsed as ASTCursorSpecification
.
6.21.0
Deprecated APIs
Internal API
Those APIs are not intended to be used by clients, and will be hidden or removed with PMD 7.0.0.
You can identify them with the @InternalApi
annotation. You’ll also get a deprecation warning.
JavaLanguageHandler
JavaLanguageParser
JavaDataFlowHandler
- Implementations of
RuleViolationFactory
in each language module, egJavaRuleViolationFactory
. See javadoc ofRuleViolationFactory
. -
Implementations of
RuleViolation
in each language module, egJavaRuleViolation
. See javadoc ofRuleViolation
. RuleFactory
RuleBuilder
- Constructors of
RuleSetFactory
, use factory methods fromRulesetsFactoryUtils
instead AbstractApexNode
-
AbstractApexNodeBase
, and the relatedvisit
methods onApexParserVisitor
and its implementations. UseApexNode
instead, now considers comments too. CharStream
,JavaCharStream
,SimpleCharStream
: these are APIs used by our JavaCC implementations and that will be moved/refactored for PMD 7.0.0. They should not be used, extended or implemented directly.- All classes generated by JavaCC, eg
JJTJavaParserState
. This includes token classes, which will be replaced with a single implementation, and subclasses ofParseException
, whose usages will be replaced by just that superclass.
For removal
- pmd-core
- Many methods on the
Node
interface andAbstractNode
base class. See their javadoc for details. Node#isFindBoundary
is deprecated for XPath queries.
- Many methods on the
- pmd-java
AbstractJavaParser
AbstractJavaHandler
ASTAnyTypeDeclaration.TypeKind
ASTAnyTypeDeclaration#getTypeKind
JavaQualifiedName
ASTCatchStatement#getBlock
ASTCompilationUnit#declarationsAreInDefaultPackage
JavaQualifiableNode
net.sourceforge.pmd.lang.java.qname
and its contentsMethodLikeNode
- Its methods will also be removed from its implementations,
ASTMethodOrConstructorDeclaration
,ASTLambdaExpression
.
- Its methods will also be removed from its implementations,
ASTAnyTypeDeclaration#getImage
will be removed. Please usegetSimpleName()
instead. This affectsASTAnnotationTypeDeclaration#getImage
,ASTClassOrInterfaceDeclaration#getImage
, andASTEnumDeclaration#getImage
.- Several methods of
ASTTryStatement
, replacements with other names have been added. This includes the XPath attribute@Finally
, replace it with a test forchild::FinallyStatement
. - Several methods named
getGuardExpressionNode
are replaced withgetCondition
. This affects the following nodes: WhileStatement, DoStatement, ForStatement, IfStatement, AssertStatement, ConditionalExpression. ASTYieldStatement
will not implementTypeNode
anymore come 7.0.0. Test the type of the expression nested within it.
6.20.0
No changes.
6.19.0
Deprecated APIs
For removal
- pmd-core
- All the package
net.sourceforge.pmd.dcd
and its subpackages. SeeDCD
. - In
LanguageRegistry
: RuleSet#getExcludePatterns
. Use the new methodgetFileExclusions
instead.RuleSet#getIncludePatterns
. Use the new methodgetFileInclusions
instead.Parser#canParse
Parser#getSuppressMap
RuleBuilder#RuleBuilder
. Use the new constructor with the correct ResourceLoader instead.RuleFactory#RuleFactory
. Use the new constructor with the correct ResourceLoader instead.
- All the package
- pmd-java
CanSuppressWarnings
and its implementationsisSuppressed
getDeclaringType
.isSupressed
ASTMethodDeclarator
getMethodName
getBlock
getParameterCount
- pmd-apex
CanSuppressWarnings
and its implementationsisSupressed
Internal APIs
- pmd-core
- All the package
net.sourceforge.pmd.util
and its subpackages, exceptnet.sourceforge.pmd.util.datasource
andnet.sourceforge.pmd.util.database
. GridBagHelper
ColumnDescriptor
- All the package
6.18.0
Changes to Renderer
-
Each renderer has now a new method
Renderer#setUseShortNames
which is used for implementing the “shortnames” CLI option. The method is automatically called by PMD, if this CLI option is in use. When rendering filenames to the report, the new helper methodAbstractRenderer#determineFileName
should be used. This will change the filename to a short name, if the CLI option “shortnames” is used.Not adjusting custom renderers will make them render always the full file names and not honoring the CLI option “shortnames”.
Deprecated APIs
For removal
- The methods
ASTImportDeclaration#getImportedNameNode
andASTImportDeclaration#getPackage
have been deprecated and will be removed with PMD 7.0.0. - The method
RuleContext#setSourceCodeFilename
has been deprecated and will be removed. The already existing methodRuleContext#setSourceCodeFile
should be used instead. The methodRuleContext#getSourceCodeFilename
still exists and returns just the filename without the full path. - The method
AbstractPMDProcessor#filenameFrom
has been deprecated. It was used to determine a “short name” of the file being analyzed, so that the report can use short names. However, this logic has been moved to the renderers. - The methods
Report#metrics
andReport#hasMetrics
have been deprecated. They were leftovers from a previous deprecation round targetingStatisticalRule
.
Internal APIs
Those APIs are not intended to be used by clients, and will be hidden or removed with PMD 7.0.0. You can identify them with the @InternalApi
annotation. You’ll also get a deprecation warning.
- pmd-core
- pmd-java
net.sourceforge.pmd.lang.java.typeresolution
: Everything, including subpackages, exceptTypeHelper
andJavaTypeDefinition
.ASTCompilationUnit#getClassTypeResolver
6.17.0
No changes.
6.16.0
Deprecated APIs
Reminder: Please don’t use members marked with the annotation
InternalApi
, as they will likely be removed, hidden, or otherwise intentionally broken with 7.0.0.
In ASTs
As part of the changes we’d like to do to AST classes for 7.0.0, we would like to hide some methods and constructors that rule writers should not have access to. The following usages are now deprecated in the Java AST (with other languages to come):
- Manual instantiation of nodes. Constructors of node classes are deprecated and marked
InternalApi
. Nodes should only be obtained from the parser, which for rules, means that never need to instantiate node themselves. Those constructors will be made package private with 7.0.0. - Subclassing of abstract node classes, or usage of their type. Version 7.0.0 will bring a new set of abstractions that will be public API, but the base classes are and will stay internal. You should not couple your code to them.
- Setters found in any node class or interface. Rules should consider the AST immutable. We will make those setters package private with 7.0.0.
Please look at net.sourceforge.pmd.lang.java.ast
to find out the full list
of deprecations.
6.15.0
Deprecated APIs
For removal
- The
DumpFacades
in all languages, that could be used to transform a AST into a textual representation, will be removed with PMD 7. The rule designer is a better way to inspect nodes. net.sourceforge.pmd.lang.apex.ast.DumpFacade
net.sourceforge.pmd.lang.java.ast.DumpFacade
net.sourceforge.pmd.lang.ecmascript.ast.DumpFacade
net.sourceforge.pmd.lang.jsp.ast.DumpFacade
net.sourceforge.pmd.lang.plsql.ast.DumpFacade
net.sourceforge.pmd.lang.vf.ast.DumpFacade
net.sourceforge.pmd.lang.vm.ast.AbstractVmNode#dump
net.sourceforge.pmd.lang.xml.ast.DumpFacade
- The method
LanguageVersionHandler#getDumpFacade
will be removed as well. It is deprecated, along with all its implementations in the subclasses ofLanguageVersionHandler
.
6.14.0
No changes.
6.13.0
Command Line Interface
The start scripts run.sh
, pmd.bat
and cpd.bat
support the new environment variable PMD_JAVA_OPTS
.
This can be used to set arbitrary JVM options for running PMD, such as memory settings (e.g. PMD_JAVA_OPTS=-Xmx512m
)
or enable preview language features (e.g. PMD_JAVA_OPTS=--enable-preview
).
The previously available variables such as OPTS
or HEAPSIZE
are deprecated and will be removed with PMD 7.0.0.
Deprecated API
-
CodeClimateRule
is deprecated in 7.0.0 because it was unused for 2 years and created an unwanted dependency. Properties “cc_categories”, “cc_remediation_points_multiplier”, “cc_block_highlighting” will also be removed. See #1702 for more. -
The Apex ruleset
rulesets/apex/ruleset.xml
has been deprecated and will be removed in 7.0.0. Please use the new quickstart rulesetrulesets/apex/quickstart.xml
instead.
6.12.0
No changes.
6.11.0
StatisticalRule
and the related helper classes and base rule classes are deprecated for removal in 7.0.0. This includes all ofnet.sourceforge.pmd.stat
andnet.sourceforge.pmd.lang.rule.stat
, and alsoAbstractStatisticalJavaRule
,AbstractStatisticalApexRule
and the like. The methodsReport#addMetric
andmetricAdded
will also be removed.setProperty
is deprecated, becauseMultiValuePropertyDescriptor
is deprecated as well.
6.10.0
Properties framework
The properties framework is about to get a lifting, and for that reason, we need to deprecate a lot of APIs to remove them in 7.0.0. The proposed changes to the API are described on the wiki
Changes to how you define properties
-
Construction of property descriptors has been possible through builders since 6.0.0. The 7.0.0 API will only allow construction through builders. The builder hierarchy, currently found in the package
net.sourceforge.pmd.properties.builders
, is being replaced by the simplerPropertyBuilder
. Their APIs enjoy a high degree of source compatibility. -
Concrete property classes like
IntegerProperty
andStringMultiProperty
will gradually all be deprecated until 7.0.0. Their usages should be replaced by direct usage of thePropertyDescriptor
interface, e.g.PropertyDescriptor<Integer>
orPropertyDescriptor<List<String>>
. -
Instead of spreading properties across countless classes, the utility class
PropertyFactory
will become from 7.0.0 on the only provider for property descriptor builders. Each current property type will be replaced by a corresponding method onPropertyFactory
:IntegerProperty
is replaced byPropertyFactory#intProperty
IntegerMultiProperty
is replaced byPropertyFactory#intListProperty
FloatProperty
andDoubleProperty
are both replaced byPropertyFactory#doubleProperty
. Having a separate property for floats wasn’t that useful.- Similarly,
FloatMultiProperty
andDoubleMultiProperty
are replaced byPropertyFactory#doubleListProperty
.
- Similarly,
StringProperty
is replaced byPropertyFactory#stringProperty
StringMultiProperty
is replaced byPropertyFactory#stringListProperty
-
RegexProperty
is replaced byPropertyFactory#regexProperty
EnumeratedProperty
is replaced byPropertyFactory#enumProperty
EnumeratedProperty
is replaced byPropertyFactory#enumListProperty
BooleanProperty
is replaced byPropertyFactory#booleanProperty
- Its multi-valued counterpart,
BooleanMultiProperty
, is not replaced, because it doesn’t have a use case.
- Its multi-valued counterpart,
CharacterProperty
is replaced byPropertyFactory#charProperty
CharacterMultiProperty
is replaced byPropertyFactory#charListProperty
LongProperty
is replaced byPropertyFactory#longIntProperty
LongMultiProperty
is replaced byPropertyFactory#longIntListProperty
MethodProperty
,FileProperty
,TypeProperty
and their multi-valued counterparts are discontinued for lack of a use-case, and have no planned replacement in 7.0.0 for now.
Here’s an example:
// Before 7.0.0, these are equivalent:
IntegerProperty myProperty = new IntegerProperty("score", "Top score value", 1, 100, 40, 3.0f);
IntegerProperty myProperty = IntegerProperty.named("score").desc("Top score value").range(1, 100).defaultValue(40).uiOrder(3.0f);
// They both map to the following in 7.0.0
PropertyDescriptor<Integer> myProperty = PropertyFactory.intProperty("score").desc("Top score value").require(inRange(1, 100)).defaultValue(40);
You’re highly encouraged to migrate to using this new API as soon as possible, to ease your migration to 7.0.0.
Architectural simplifications
-
EnumeratedPropertyDescriptor
,NumericPropertyDescriptor
,PackagedPropertyDescriptor
, and the related builders (innet.sourceforge.pmd.properties.builders
) will be removed. These specialized interfaces allowed additional constraints to be enforced on the value of a property, but made the property class hierarchy very large and impractical to maintain. Their functionality will be mapped uniformly toPropertyConstraint
s, which will allow virtually any constraint to be defined, and improve documentation and error reporting. The related methodsPropertyTypeId#isPropertyNumeric
andPropertyTypeId#isPropertyPackaged
are also deprecated. -
MultiValuePropertyDescriptor
andSingleValuePropertyDescriptor
are deprecated. 7.0.0 will introduce a new XML syntax which will remove the need for such a divide between single- and multi-valued properties. The methodPropertyDescriptor#isMultiValue
will be removed accordingly.
Changes to the PropertyDescriptor interface
preferredRowCount
is deprecated with no intended replacement. It was never implemented, and does not belong in this interface. The methodsuiOrder
andcompareTo(PropertyDescriptor)
are deprecated for the same reason. These methods mix presentation logic with business logic and are not necessary for PropertyDescriptors to work.PropertyDescriptor
will not extendComparable<PropertyDescriptor>
anymore come 7.0.0.- The method
propertyErrorFor
is deprecated and will be removed with no intended replacement. It’s really just a shortcut forprop.errorFor(rule.getProperty(prop))
. T
valueFrom(String)
andString
asDelimitedString
(T)
are deprecated and will be removed. These were used to serialize and deserialize properties to/from a string, but 7.0.0 will introduce a more flexible XML syntax which will make them obsolete.isMultiValue
andtype
are deprecated and won’t be replaced. The new XML syntax will remove the need for a divide between multi- and single-value properties, and will allow arbitrary types to be represented. Since arbitrary types may be represented,type
will become obsolete as it can’t represent generic types, which will nevertheless be representable with the XML syntax. It was only used for documentation, but a new way to document these properties exhaustively will be added with 7.0.0.errorFor
is deprecated as its return type will be changed toOptional<String>
with the shift to Java 8.
Deprecated APIs
For internalization
-
The implementation of the adapters for the XPath engines Saxon and Jaxen (package
net.sourceforge.pmd.lang.ast.xpath
) are now deprecated. They’ll be moved to an internal package come 7.0.0. OnlyAttribute
remains public API. -
The classes
PropertyDescriptorField
,PropertyDescriptorBuilderConversionWrapper
, and the methodsPropertyDescriptor#attributeValuesById
,PropertyDescriptor#isDefinedExternally
andPropertyTypeId#getFactory
. These were used to read and write properties to and from XML, but were not intended as public API. -
The class
ValueParserConstants
and the interfaceValueParser
. -
All classes from
net.sourceforge.pmd.lang.java.metrics.impl.visitors
are now considered internal API. They’re deprecated and will be moved into an internal package with 7.0.0. To implement your own metrics visitors,JavaParserVisitorAdapter
should be directly subclassed. -
LanguageVersionHandler#getDataFlowHandler()
,LanguageVersionHandler#getDFAGraphRule()
For removal
-
All classes from
net.sourceforge.pmd.properties.modules
will be removed. -
The interface
Dimensionable
has been deprecated. It gets in the way of a grammar change for 7.0.0 and won’t be needed anymore (see #997). -
Several methods from
ASTLocalVariableDeclaration
andASTFieldDeclaration
have also been deprecated: -
ASTFieldDeclaration
won’t be aTypeNode
come 7.0.0, sogetType
andgetTypeDefinition
are deprecated. -
The method
getVariableName
on those two nodes will be removed, too. -
All these are deprecated because those nodes may declare several variables at once, possibly with different types (and obviously with different names). They both implement
Iterator<
ASTVariableId
>
though, so you should iterate on each declared variable. See #910. -
Visitor decorators are now deprecated and will be removed in PMD 7.0.0. They were originally a way to write composable visitors, used in the metrics framework, but they didn’t prove cost-effective.
-
In
net.sourceforge.pmd.lang.java.ast
:JavaParserDecoratedVisitor
,JavaParserControllessVisitor
,JavaParserControllessVisitorAdapter
, andJavaParserVisitorDecorator
are deprecated with no intended replacement. -
The LanguageModules of several languages, that only support CPD execution, have been deprecated. These languages are not fully supported by PMD, so having a language module does not make sense. The functionality of CPD is not affected by this change. The following classes have been deprecated and will be removed with PMD 7.0.0:
CppHandler
CppLanguageModule
CppParser
CsLanguageModule
FortranLanguageModule
GroovyLanguageModule
MatlabHandler
MatlabLanguageModule
MatlabParser
ObjectiveCHandler
ObjectiveCLanguageModule
ObjectiveCParser
PhpLanguageModule
PythonHandler
PythonLanguageModule
PythonParser
- Optional AST processing stages like symbol table, type resolution or data-flow analysis will be reified
in 7.0.0 to factorise common logic and make them extensible. Further explanations about this change can be
found on #1426. Consequently, the following APIs are deprecated for
removal:
- In
Rule
:isDfa()
,isTypeResolution()
,isMultifile()
and their respective setters. - In
RuleSet
:usesDFA(Language)
,usesTypeResolution(Language)
,usesMultifile(Language)
- In
RuleSets
:usesDFA(Language)
,usesTypeResolution(Language)
,usesMultifile(Language)
- In
LanguageVersionHandler
:getDataFlowFacade()
,getSymbolFacade()
,getSymbolFacade(ClassLoader)
,getTypeResolutionFacade(ClassLoader)
,getQualifiedNameResolutionFacade(ClassLoader)
- In
6.9.0
No changes.
6.8.0
-
A couple of methods and fields in
net.sourceforge.pmd.properties.AbstractPropertySource
have been deprecated, as they are replaced by already existing functionality or expose internal implementation details:propertyDescriptors
,propertyValuesByDescriptor
,copyPropertyDescriptors()
,copyPropertyValues()
,ignoredProperties()
,usesDefaultValues()
,useDefaultValueFor()
. -
Some methods in
net.sourceforge.pmd.properties.PropertySource
have been deprecated as well:usesDefaultValues()
,useDefaultValueFor()
,ignoredProperties()
. -
The class
net.sourceforge.pmd.lang.rule.AbstractDelegateRule
has been deprecated and will be removed with PMD 7.0.0. It is internally only in use by RuleReference. -
The default constructor of
net.sourceforge.pmd.lang.rule.RuleReference
has been deprecated and will be removed with PMD 7.0.0. RuleReferences should only be created by providing a Rule and a RuleSetReference. Furthermore, the following methods are deprecated:setRuleReference()
,hasOverriddenProperty()
,usesDefaultValues()
,useDefaultValueFor()
.
6.7.0
-
All classes in the package
net.sourceforge.pmd.lang.dfa.report
have been deprecated and will be removed with PMD 7.0.0. This includes the classnet.sourceforge.pmd.lang.dfa.report.ReportTree
. The reason is, that this class is very specific to Java and not suitable for other languages. It has only been used forYAHTMLRenderer
, which has been rewritten to work without these classes. -
The nodes RUNSIGNEDSHIFT and RSIGNEDSHIFT are deprecated and will be removed from the AST with PMD 7.0.0. These represented the operator of ShiftExpression in two cases out of three, but they’re not needed and make ShiftExpression inconsistent. The operator of a ShiftExpression is now accessible through ShiftExpression#getOperator.
6.5.0
-
The utility class
CommentUtil
has been deprecated and will be removed with PMD 7.0.0. Its methods have been intended to parse javadoc tags. A more useful solution will be added around the AST nodeFormalComment
, which contains as childrenJavadocElement
nodes, which in turn provide access to theJavadocTag
.All comment AST nodes (
FormalComment
,MultiLineComment
,SingleLineComment
) have a new methodgetFilteredComment()
which provide access to the comment text without the leading/*
markers. -
The method
AbstractCommentRule.tagsIndicesIn()
has been deprecated and will be removed with PMD 7.0.0. It is not very useful, since it doesn’t extract the information in a useful way. You would still need check, which tags have been found, and with which data they might be accompanied.
6.4.0
- The following classes in package
net.sourceforge.pmd.benchmark
have been deprecated:Benchmark
,Benchmarker
,BenchmarkReport
,BenchmarkResult
,RuleDuration
,StringBuilderCR
andTextReport
. Their API is not supported anymore and is disconnected from the internals of PMD. Use the newer API based aroundTimeTracker
instead, which can be found in the same package. - The class
TypeOfFunction
has been deprecated. Use the newerTypeIsFunction
in the same package. - The
typeof
methods inJavaFunctions
have been deprecated. Use the newertypeIs
method in the same class instead. - The methods
isA
,isEither
andisNeither
ofTypeHelper
. Use the newisExactlyAny
andisExactlyNone
methods in the same class instead.
6.2.0
-
The static method
PMDParameters#transformParametersIntoConfiguration
is now deprecated, for removal in 7.0.0. The new instance methodtoConfiguration
replaces it. -
The method
ASTConstructorDeclaration#getParameters
has been deprecated in favor of the new methodgetFormalParameters
. This method is available for bothASTConstructorDeclaration
andASTMethodDeclaration
.
6.1.0
- The method
getXPathNodeName
is added to theNode
interface, which removes the use oftoString
of a node to get its XPath element name (see #569).- The default implementation provided in
AbstractNode
, will be removed with 7.0.0 - With 7.0.0, the
Node.toString
method will not necessarily provide its XPath node name anymore.
- The default implementation provided in
-
The interface
net.sourceforge.pmd.cpd.Renderer
has been deprecated. A new interfaceCPDRenderer
has been introduced to replace it. The main difference is that the new interface is meant to render directly to ajava.io.Writer
rather than to a String. This allows to greatly reduce the memory footprint of CPD, as on large projects, with many duplications, it was causingOutOfMemoryError
s (see #795).net.sourceforge.pmd.cpd.FileReporter
has also been deprecated as part of this change, as it’s no longer needed.
6.0.1
- The constant
PMD#VERSION
has been deprecated and will be removed with PMD 7.0.0. Please usePMDVersion#VERSION
instead.
🐛 Fixed Issues
- miscellaneous
- #881: [all] Breaking API changes for 7.0.0
- #896: [all] Use slf4j
- #1431: [ui] Remove old GUI applications (designerold, bgastviewer)
- #1451: [core] RulesetFactoryCompatibility stores the whole ruleset file in memory as a string
- #2496: Update PMD 7 Logo on landing page
- #2497: PMD 7 Logo page
- #2498: Update PMD 7 Logo in documentation
- #3797: [all] Use JUnit5
- #4462: Provide Software Bill of Materials (SBOM)
- #4460: Fix assembly-plugin warnings
- #4582: [dist] Download link broken
- #4586: Use explicit encoding in ruleset xml files
- #4642: Update regression tests with Java 21 language features
- #4691: [CVEs] Critical and High CEVs reported on PMD and PMD dependencies
- #4699: Make PMD buildable with java 21
- #4736: [ci] Improve build procedure
- #4741: Add pmd-compat6 module for maven-pmd-plugin
- #4749: Fixes NoSuchMethodError on processing errors in pmd-compat6
- #4776: [ci] Upgrade to ruby 3
- #4796: Remove deprecated and release rulesets
- #4823: Update to use renamed pmd-designer
- #4827: [compat6] Support config errors and cpd for csharp
- #4830: Consolidate packages in each maven module
- #4867: [dist] ./mvnw command not found in dist-src
- ant
- #4080: [ant] Split off Ant integration into a new submodule
- core
- #880: [core] Make visitors generic
- #1027: [core] Apply the new PropertyDescriptor<Pattern> type where applicable
- #1204: [core] Allow numeric properties in XML to be within an unbounded range
- #1622: [core] NodeStream API
- #1687: [core] Deprecate and Remove XPath 1.0 support
- #1785: [core] Allow abstract node types to be valid rulechain visits
- #1825: [core] Support NoAttribute for XPath
- #2038: [core] Remove DCD
- #2218: [core]
isFindBoundary
should not be an attribute - #2234: [core] Consolidate PMD CLI into a single command
- #2239: [core] Merging Javacc build scripts
- #2500: [core] Clarify API for ANTLR based languages
- #2518: [core] Language properties
- #2602: [core] Remove ParserOptions
- #2614: [core] Upgrade Saxon, add XPath 3.1, remove Jaxen
- #2696: [core] Remove DFA
- #2821: [core] Rule processing error filenames are missing paths
- #2873: [core] Utility classes in pmd 7
- #2885: [core] Error recovery mode
- #3203: [core] Replace RuleViolationFactory implementations with ViolationDecorator
- #3692: [core] Analysis listeners
- #3782: [core] Language lifecycle
- #3815: [core] Update Saxon HE to 10.7
- #3893: [core] Text documents
- #3902: [core] Violation decorators
- #3903: [core] Consolidate
n.s.pmd.reporting
package - #3905: [core] Stabilize tree export API
- #3917: [core] Consolidate
n.s.pmd.lang.rule
package - #3918: [core] Make LanguageRegistry non static
- #3919: [core] Merge CPD and PMD language
- #3922: [core] Better error reporting for the ruleset parser
- #4035: [core] ConcurrentModificationException in DefaultRuleViolationFactory
- #4065: [core] Rename TokenMgrError to LexException, Tokenizer to CpdLexer
- #4120: [core] Explicitly name all language versions
- #4204: [core] Provide a CpdAnalysis class as a programmatic entry point into CPD
- #4301: [core] Remove deprecated property concrete classes
- #4302: [core] Migrate Property Framework API to Java 8
- #4309: [core] Cleanups in XPath area
- #4312: [core] Remove unnecessary property
color
and system propertypmd.color
inTextColorRenderer
- #4313: [core] Remove support for <lang>-<ruleset> hyphen notation for ruleset references
- #4314: [core] Remove ruleset compatibility filter (RuleSetFactoryCompatibility) and CLI option
--no-ruleset-compatibility
- #4323: [core] Refactor CPD integration
- #4348: [core] Consolidate @InternalApi classes
- #4349: [core] Cleanup remaining experimental and deprecated API
- #4353: [core] Micro optimizations for Node API
- #4365: [core] Improve benchmarking
- #4397: [core] Refactor CPD
- #4378: [core] Ruleset loading processes commented rules
- #4420: [core] Remove PMD.EOL
- #4425: [core] Replace TextFile::pathId
- #4454: [core] “Unknown option: ‘-min’” but is referenced in documentation
- #4611: [core] Fix loading language properties from env vars
- #4621: [core] Make
ClasspathClassLoader::getResource
child first - #4674: [core] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.CachedClass
- #4694: [core] Fix line/col numbers in TokenMgrError
- #4717: [core] XSLTRenderer doesn’t close report file
- #4750: [core] Fix flaky SummaryHTMLRenderer
- #4782: [core] Avoid using getImage/@Image
- cli
- #2234: [core] Consolidate PMD CLI into a single command
- #3828: [core] Progress reporting
- #4079: [cli] Split off CLI implementation into a pmd-cli submodule
- #4423: [cli] Fix NPE when only
--file-list
is specified - #4482: [cli] pmd.bat can only be executed once
- #4484: [cli] ast-dump with no properties produce an NPE
- #4594: [cli] Change completion generation to runtime
- #4685: [cli] Clarify CPD documentation, fix positional parameter handling
- #4723: [cli] Launch fails for “bash pmd”
- doc
- #995: [doc] Document API evolution principles as ADR
- #2501: [doc] Verify ANTLR Documentation
- #2511: [doc] Review guides for writing java/xpath rules for correctness with PMD 7
- #3175: [doc] Document language module features
- #4294: [doc] Migration Guide for upgrading PMD 6 ➡️ 7
- #4303: [doc] Document new property framework
- #4308: [doc] Document XPath API @DeprecatedAttribute
- #4319: [doc] Document TypeRes API and Symbols API
- #4438: [doc] Documentation links in VS Code are outdated
- #4521: [doc] Website is not mobile friendly
- #4676: [doc] Clarify how CPD
--ignore-literals
and--ignore-identifiers
work - #4659: [doc] Improve ant documentation
- #4669: [doc] Add bld PMD Extension to Tools / Integrations
- #4704: [doc] Multivalued properties do not accept | as a separator
- testing
Language specific fixes:
- apex
- #1937: [apex] Apex should only have a single RootNode
- #1648: [apex,vf] Remove CodeClimate dependency
- #1750: [apex] Remove apex statistical rules
- #2836: [apex] Remove Apex ProjectMirror
- #3766: [apex] Replace Jorje with fully open source front-end
- #3973: [apex] Update parser to support new ‘as user’ keywords (User Mode for Database Operations)
- #4427: [apex] ApexBadCrypto test failing to detect inline code
- #4453: [apex] [7.0-rc1] Exception while initializing Apexlink (Index 34812 out of bounds for length 34812)
- #4828: [apex] Support null coalescing operator ?? (apex 60)
- #4845: [apex] Use same ANLTR version for apex-parser
- apex-design
- apex-documentation
- #4774: [apex] ApexDoc false-positive for the first method of an annotated Apex class
- apex-performance
- #4675: [apex] New Rule: OperationWithHighCostInLoop
- apex-security
- #4646: [apex] ApexSOQLInjection does not recognise SObjectType or SObjectField as safe variable types
- groovy
- #4726: [groovy] Support Groovy to 3 and 4 and CPD suppressions
- java
- #520: [java] Allow
@SuppressWarnings
with constants instead of literals - #864: [java] Similar/duplicated implementations for determining FQCN
- #905: [java] Add new node for anonymous class declaration
- #910: [java] AST inconsistency between primitive and reference type arrays
- #997: [java] Java8 parsing corner case with annotated array types
- #998: [java] AST inconsistencies around FormalParameter
- #1019: [java] Breaking Java Grammar changes for PMD 7.0.0
- #1124: [java] ImmutableList implementation in the qname codebase
- #1128: [java] Improve ASTLocalVariableDeclaration
- #1150: [java] ClassOrInterfaceType AST improvements
- #1207: [java] Resolve explicit types using FQCNs, without hitting the classloader
- #1307: [java] AccessNode API changes
- #1367: [java] Parsing error on annotated inner class
- #1661: [java] About operator nodes
- #2366: [java] Remove qualified names
- #2819: [java] GLB bugs in pmd 7
- #3642: [java] Parse error on rare extra dimensions on method return type on annotation methods
- #3763: [java] Ambiguous reference error in valid code
- #3749: [java] Improve
isOverridden
in ASTMethodDeclaration - #3750: [java] Make symbol table support instanceof pattern bindings
- #3751: [java] Rename some node types
- #3752: [java] Expose annotations in symbol API
- #4237: [java] Cleanup handling of Java comments
- #4317: [java] Some AST nodes should not be TypeNodes
- #4359: [java] Type resolution fails with NPE when the scope is not a type declaration
- #4367: [java] Move testrule TypeResTest into internal
- #4383: [java] IllegalStateException: Object is not an array type!
- #4401: [java] PMD 7 fails to build under Java 19
- #4405: [java] Processing error with ArrayIndexOutOfBoundsException
- #4583: [java] Support JDK 21 (LTS)
- #4628: [java] Support loading classes from java runtime images
- #4753: [java] PMD crashes while using generics and wildcards
- #4757: [java] Intermittent NPEs while analyzing Java code
- #4794: [java] Support JDK 22
- #520: [java] Allow
- java-bestpractices
- #342: [java] AccessorMethodGeneration: Name clash with another public field not properly handled
- #755: [java] AccessorClassGeneration false positive for private constructors
- #770: [java] UnusedPrivateMethod yields false positive for counter-variant arguments
- #807: [java] AccessorMethodGeneration false positive with overloads
- #833: [java] ForLoopCanBeForeach should consider iterating on this
- #1189: [java] UnusedPrivateMethod false positive from inner class via external class
- #1205: [java] Improve ConstantsInInterface message to mention alternatives
- #1212: [java] Don’t raise JUnitTestContainsTooManyAsserts on JUnit 5’s assertAll
- #1422: [java] JUnitTestsShouldIncludeAssert false positive with inherited @Rule field
- #1455: [java] JUnitTestsShouldIncludeAssert: False positives for assert methods named “check” and “verify”
- #1563: [java] ForLoopCanBeForeach false positive with method call using index variable
- #1565: [java] JUnitAssertionsShouldIncludeMessage false positive with AssertJ
- #1747: [java] PreserveStackTrace false-positive
- #1969: [java] MissingOverride false-positive triggered by package-private method overwritten in another package by extending class
- #1998: [java] AccessorClassGeneration false-negative: subclass calls private constructor
- #2130: [java] UnusedLocalVariable: false-negative with array
- #2147: [java] JUnitTestsShouldIncludeAssert - false positives with lambdas and static methods
- #2464: [java] LooseCoupling must ignore class literals: ArrayList.class
- #2542: [java] UseCollectionIsEmpty can not detect the case
foo.bar().size()
- #2650: [java] UseTryWithResources false positive when AutoCloseable helper used
- #2796: [java] UnusedAssignment false positive with call chains
- #2797: [java] MissingOverride long-standing issues
- #2806: [java] SwitchStmtsShouldHaveDefault false-positive with Java 14 switch non-fallthrough branches
- #2822: [java] LooseCoupling rule: Extend to cover user defined implementations and interfaces
- #2843: [java] Fix UnusedAssignment FP with field accesses
- #2882: [java] UseTryWithResources - false negative for explicit close
- #2883: [java] JUnitAssertionsShouldIncludeMessage false positive with method call
- #2890: [java] UnusedPrivateMethod false positive with generics
- #2946: [java] SwitchStmtsShouldHaveDefault false positive on enum inside enums
- #3672: [java] LooseCoupling - fix false positive with generics
- #3675: [java] MissingOverride - fix false positive with mixing type vars
- #3858: [java] UseCollectionIsEmpty should infer local variable type from method invocation
- #4433: [java] [7.0-rc1] ReplaceHashtableWithMap on java.util.Properties
- #4492: [java] GuardLogStatement gives false positive when argument is a Java method reference
- #4503: [java] JUnitTestsShouldIncludeAssert: false negative with TestNG
- #4516: [java] UnusedLocalVariable: false-negative with try-with-resources
- #4517: [java] UnusedLocalVariable: false-negative with compound assignments
- #4518: [java] UnusedLocalVariable: false-positive with multiple for-loop indices
- #4603: [java] UnusedAssignment false positive in record compact constructor
- #4625: [java] UnusedPrivateMethod false positive: Autoboxing into Number
- #4634: [java] JUnit4TestShouldUseTestAnnotation false positive with TestNG
- #4817: [java] UnusedPrivateMethod false-positive used in lambda
- java-codestyle
- #1208: [java] PrematureDeclaration rule false-positive on variable declared to measure time
- #1429: [java] PrematureDeclaration as result of method call (false positive)
- #1480: [java] IdenticalCatchBranches false positive with return expressions
- #1673: [java] UselessParentheses false positive with conditional operator
- #1790: [java] UnnecessaryFullyQualifiedName false positive with enum constant
- #1918: [java] UselessParentheses false positive with boolean operators
- #2134: [java] PreserveStackTrace not handling
Throwable.addSuppressed(...)
- #2299: [java] UnnecessaryFullyQualifiedName false positive with similar package name
- #2391: [java] UseDiamondOperator FP when expected type and constructed type have a different parameterization
- #2528: [java] MethodNamingConventions - JUnit 5 method naming not support ParameterizedTest
- #2739: [java] UselessParentheses false positive for string concatenation
- #2748: [java] UnnecessaryCast false positive with unchecked cast
- #2847: [java] New Rule: Use Explicit Types
- #2973: [java] New rule: UnnecessaryBoxing
- #3195: [java] Improve rule UnnecessaryReturn to detect more cases
- #3218: [java] Generalize UnnecessaryCast to flag all unnecessary casts
- #3221: [java] PrematureDeclaration false positive for unused variables
- #3238: [java] Improve ExprContext, fix FNs of UnnecessaryCast
- #3500: [java] UnnecessaryBoxing - check for Integer.valueOf(String) calls
- #4239: [java] UnnecessaryLocalBeforeReturn - false positive with catch clause
- #4268: [java] CommentDefaultAccessModifier: false positive with TestNG annotations
- #4273: [java] CommentDefaultAccessModifier ignoredAnnotations should include “org.junit.jupiter.api.extension.RegisterExtension” by default
- #4357: [java] Fix IllegalStateException in UseDiamondOperator rule
- #4432: [java] [7.0-rc1] UnnecessaryImport - Unused static import is being used
- #4455: [java] FieldNamingConventions: false positive with lombok’s @UtilityClass
- #4487: [java] UnnecessaryConstructor: false-positive with @Inject and @Autowired
- #4511: [java] LocalVariableCouldBeFinal shouldn’t report unused variables
- #4512: [java] MethodArgumentCouldBeFinal shouldn’t report unused parameters
- #4557: [java] UnnecessaryImport FP with static imports of overloaded methods
- #4578: [java] CommentDefaultAccessModifier comment needs to be before annotation if present
- #4631: [java] UnnecessaryFullyQualifiedName fails to recognize illegal self reference in enums
- #4645: [java] CommentDefaultAccessModifier - False Positive with JUnit5’s ParameterizedTest
- #4754: [java] EmptyControlStatementRule: Add allowCommentedBlocks property
- #4816: [java] UnnecessaryImport false-positive on generic method call with on lambda
- java-design
- #174: [java] SingularField false positive with switch in method that both assigns and reads field
- #1014: [java] LawOfDemeter: False positive with lambda expression
- #1605: [java] LawOfDemeter: False positive for standard UTF-8 charset name
- #2160: [java] Issues with Law of Demeter
- #2175: [java] LawOfDemeter: False positive for chained methods with generic method call
- #2179: [java] LawOfDemeter: False positive with static property access - should treat class-level property as global object, not dot-accessed property
- #2180: [java] LawOfDemeter: False positive with Thread and ThreadLocalRandom
- #2182: [java] LawOfDemeter: False positive with package-private access
- #2188: [java] LawOfDemeter: False positive with fields assigned to local vars
- #2536: [java] ClassWithOnlyPrivateConstructorsShouldBeFinal can’t detect inner class
- #3668: [java] ClassWithOnlyPrivateConstructorsShouldBeFinal - fix FP with inner private classes
- #3754: [java] SingularField false positive with read in while condition
- #3786: [java] SimplifyBooleanReturns should consider operator precedence
- #3840: [java] LawOfDemeter disallows method call on locally created object
- #4238: [java] Make LawOfDemeter not use the rulechain
- #4254: [java] ImmutableField - false positive with Lombok @Setter
- #4434: [java] [7.0-rc1] ExceptionAsFlowControl when simply propagating
- #4456: [java] FinalFieldCouldBeStatic: false positive with lombok’s @UtilityClass
- #4477: [java] SignatureDeclareThrowsException: false-positive with TestNG annotations
- #4490: [java] ImmutableField - false negative with Lombok @Getter
- #4549: [java] Make LawOfDemeter results deterministic
- java-documentation
- java-errorprone
- #659: [java] MissingBreakInSwitch - last default case does not contain a break
- #718: [java] BrokenNullCheck false positive with parameter/field confusion
- #932: [java] SingletonClassReturningNewInstance false positive with double assignment
- #1005: [java] CloneMethodMustImplementCloneable triggers for interfaces
- #1669: [java] NullAssignment - FP with ternay and null as constructor argument
- #1831: [java] DetachedTestCase reports abstract methods
- #1899: [java] Recognize @SuppressWanings(“fallthrough”) for MissingBreakInSwitch
- #2320: [java] NullAssignment - FP with ternary and null as method argument
- #2532: [java] AvoidDecimalLiteralsInBigDecimalConstructor can not detect the case
new BigDecimal(Expression)
- #2579: [java] MissingBreakInSwitch detects the lack of break in the last case
- #2880: [java] CompareObjectsWithEquals - false negative with type res
- #2893: [java] Remove special cases from rule EmptyCatchBlock
- #2894: [java] Improve MissingBreakInSwitch
- #3071: [java] BrokenNullCheck FP with PMD 6.30.0
- #3087: [java] UnnecessaryBooleanAssertion overlaps with SimplifiableTestAssertion
- #3100: [java] UseCorrectExceptionLogging FP in 6.31.0
- #3173: [java] UseProperClassLoader false positive
- #3351: [java] ConstructorCallsOverridableMethod ignores abstract methods
- #3400: [java] AvoidUsingOctalValues FN with underscores
- #3843: [java] UseEqualsToCompareStrings should consider return type
- #4063: [java] AvoidBranchingStatementAsLastInLoop: False-negative about try/finally block
- #4356: [java] Fix NPE in CloseResourceRule
- #4449: [java] AvoidAccessibilityAlteration: Possible false positive in AvoidAccessibilityAlteration rule when using Lambda expression
- #4457: [java] OverrideBothEqualsAndHashcode: false negative with anonymous classes
- #4493: [java] MissingStaticMethodInNonInstantiatableClass: false-positive about @Inject
- #4505: [java] ImplicitSwitchFallThrough NPE in PMD 7.0.0-rc1
- #4510: [java] ConstructorCallsOverridableMethod: false positive with lombok’s @Value
- #4513: [java] UselessOperationOnImmutable various false negatives with String
- #4514: [java] AvoidLiteralsInIfCondition false positive and negative for String literals when ignoreExpressions=true
- #4546: [java] OverrideBothEqualsAndHashCode ignores records
- #4719: [java] UnnecessaryCaseChange: example doc toUpperCase() should compare to a capitalized string
- java-multithreading
- #2537: [java] DontCallThreadRun can’t detect the case that call run() in
this.run()
- #2538: [java] DontCallThreadRun can’t detect the case that call run() in
foo.bar.run()
- #2577: [java] UseNotifyAllInsteadOfNotify falsely detect a special case with argument:
foo.notify(bar)
- #4483: [java] NonThreadSafeSingleton false positive with double-checked locking
- #2537: [java] DontCallThreadRun can’t detect the case that call run() in
- java-performance
- #1224: [java] InefficientEmptyStringCheck false negative in anonymous class
- #2587: [java] AvoidArrayLoops could also check for list copy through iterated List.add()
- #2712: [java] SimplifyStartsWith false-positive with AssertJ
- #3486: [java] InsufficientStringBufferDeclaration: Fix NPE
- #3848: [java] StringInstantiation: false negative when using method result
- #4070: [java] A false positive about the rule RedundantFieldInitializer
- #4458: [java] RedundantFieldInitializer: false positive with lombok’s @Value
- javascript
- #4673: [javascript] CPD: Added support for decorator notation
- kotlin
- plsql
- #4820: [plsql] WITH clause is ignored for SELECT INTO statements
- swift
- xml
- #1800: [xml] Unimplement org.w3c.dom.Node from the XmlNodeWrapper
- xml-bestpractices
- #4592: [xml] Add MissingEncoding rule
✨ External Contributions
- #1658: [core] Node support for Antlr-based languages - Matías Fraga (@matifraga)
- #1698: [core] [swift] Antlr Base Parser adapter and Swift Implementation - Lucas Soncini (@lsoncini)
- #1774: [core] Antlr visitor rules - Lucas Soncini (@lsoncini)
- #1877: [swift] Feature/swift rules - Matías Fraga (@matifraga)
- #1881: [doc] Add ANTLR documentation - Matías Fraga (@matifraga)
- #1882: [swift] UnavailableFunction Swift rule - Tomás de Lucca (@tomidelucca)
- #2830: [apex] Apexlink POC - Kevin Jones (@nawforce)
- #3866: [core] Add CLI Progress Bar - @JerritEic (@JerritEic)
- #4093: [apex] Summit-AST Apex module - Part 1 - Edward Klimoshenko (@eklimo)
- #4151: [apex] Summit-AST Apex module - Part 2 - expression nodes - Aaron Hurst (@aaronhurst-google)
- #4171: [apex] Summit-AST Apex module - Part 3 - initializers - Aaron Hurst (@aaronhurst-google)
- #4206: [apex] Summit-AST Apex module - Part 4 - statements - Aaron Hurst (@aaronhurst-google)
- #4219: [apex] Summit-AST Apex module - Part 5 - annotations, triggers, misc. - Aaron Hurst (@aaronhurst-google)
- #4242: [apex] Merge 6.52 into experimental-apex-parser - Aaron Hurst (@aaronhurst-google)
- #4251: [apex] Summit-AST Apex module - Part 6 Passing testsuite - Aaron Hurst (@aaronhurst-google)
- #4402: [javascript] CPD: add support for Typescript using antlr4 grammar - Paul Guyot (@pguyot)
- #4403: [julia] CPD: Add support for Julia code duplication - Wener (@wener-tiobe)
- #4412: [doc] Added new error msg to ConstantsInInterface - David Ljunggren (@dague1)
- #4426: [cpd] New XML to HTML XLST report format for PMD CPD - mohan-chinnappan-n (@mohan-chinnappan-n)
- #4428: [apex] ApexBadCrypto bug fix for #4427 - inline detection of hard coded values - Steven Stearns (@sfdcsteve)
- #4431: [coco] CPD: Coco support for code duplication detection - Wener (@wener-tiobe)
- #4444: [java] CommentDefaultAccessModifier - ignore org.junit.jupiter.api.extension.RegisterExtension by default - Nirvik Patel (@nirvikpatel)
- #4448: [apex] Bump summit-ast to new release 2.1.0 (and remove workaround) - Aaron Hurst (@aaronhurst-google)
- #4450: [java] Fix #4449 AvoidAccessibilityAlteration: Correctly handle Lambda expressions in PrivilegedAction scenarios - Seren (@mohui1999)
- #4452: [doc] Update PMD_APEX_ROOT_DIRECTORY documentation reference - nwcm (@nwcm)
- #4470: [cpp] CPD: Added strings as literal and ignore identifiers in sequences - Wener (@wener-tiobe)
- #4474: [java] ImmutableField: False positive with lombok (fixes #4254) - Pim van der Loos (@PimvanderLoos)
- #4479: [apex] Merge main (7.x) branch into experimental-apex-parser and fix tests - Aaron Hurst (@aaronhurst-google)
- #4488: [java] Fix #4477: A false-positive about SignatureDeclareThrowsException - AnnaDev (@LynnBroe)
- #4494: [java] Fix #4487: A false-positive about UnnecessaryConstructor and @Inject and @Autowired - AnnaDev (@LynnBroe)
- #4495: [java] Fix #4493: false-positive about MissingStaticMethodInNonInstantiatableClass and @Inject - AnnaDev (@LynnBroe)
- #4507: [java] Fix #4503: A false negative about JUnitTestsShouldIncludeAssert and testng - AnnaDev (@LynnBroe)
- #4520: [doc] Fix typo: missing closing quotation mark after CPD-END - João Dinis Ferreira (@joaodinissf)
- #4528: [apex] Update to apexlink - Kevin Jones (@nawforce)
- #4533: [java] Fix #4063: False-negative about try/catch block in Loop - AnnaDev (@LynnBroe)
- #4536: [java] Fix #4268: CommentDefaultAccessModifier - false positive with TestNG’s @Test annotation - AnnaDev (@LynnBroe)
- #4537: [java] Fix #4455: A false positive about FieldNamingConventions and UtilityClass - AnnaDev (@LynnBroe)
- #4538: [java] Fix #4456: A false positive about FinalFieldCouldBeStatic and UtilityClass - AnnaDev (@LynnBroe)
- #4540: [java] Fix #4457: false negative about OverrideBothEqualsAndHashcode - AnnaDev (@LynnBroe)
- #4541: [java] Fix #4458: A false positive about RedundantFieldInitializer and @Value - AnnaDev (@LynnBroe)
- #4542: [java] Fix #4510: A false positive about ConstructorCallsOverridableMethod and @Value - AnnaDev (@LynnBroe)
- #4553: [java] Fix #4492: GuardLogStatement gives false positive when argument is a Java method reference - Anastasiia Koba (@anastasiia-koba)
- #4562: [apex] Fixes #4556 - Update Apex bind regex match for all possible combinations - nwcm (@nwcm)
- #4637: [java] fix #4634 - JUnit4TestShouldUseTestAnnotation false positive with TestNG - Krystian Dabrowski (@krdabrowski)
- #4640: [cli] Launch script fails if run via “bash pmd” - Shai Bennathan (@shai-bennathan)
- #4649: [apex] Add SObjectType and SObjectField to list of injectable SOQL variable types - Richard Corfield (@rcorfieldffdc)
- #4651: [doc] Add “Tencent Cloud Code Analysis” in Tools / Integrations - yale (@cyw3)
- #4664: [cli] CPD: Fix NPE when only
--file-list
is specified - Wener (@wener-tiobe) - #4665: [java] Doc: Fix references AutoClosable -> AutoCloseable - Andrey Bozhko (@AndreyBozhko)
- #4673: [javascript] CPD: Added support for decorator notation - Wener (@wener-tiobe)
- #4677: [apex] Add new rule: OperationWithHighCostInLoop - Thomas Prouvot (@tprouvot)
- #4698: [swift] Add macro expansion support for swift 5.9 - Richard B. (@kenji21)
- #4706: [java] DetachedTestCase should not report on abstract methods - Debamoy Datta (@Debamoy)
- #4719: [java] UnnecessaryCaseChange: example doc toUpperCase() should compare to a capitalized string - ciufudean (@ciufudean)
- #4738: [doc] Added reference to the PMD extension for bld - Erik C. Thauvin (@ethauvin)
- #4749: Fixes NoSuchMethodError on processing errors in pmd-compat6 - Andreas Bergander (@bergander)
- #4750: [core] Fix flaky SummaryHTMLRenderer - 219sansim (@219sansim)
- #4752: [core] Fix flaky LatticeRelationTest - 219sansim (@219sansim)
- #4754: [java] EmptyControlStatementRule: Add allowCommentedBlocks property - Andreas Bergander (@bergander)
- #4759: [java] fix: remove delimiter attribute from ruleset category/java/errorprone.xml - Marcin Dąbrowski (@marcindabrowski)
- #4825: [plsql] Fix ignored WITH clause for SELECT INTO statements - Laurent Bovet (@lbovet)
- #4857: [javascript] Fix UnnecessaryBlock issues with empty statements - Oleksandr Shvets (@oleksandr-shvets)